diff mbox

arm, kbuild: Do not define "comma" twice

Message ID 1386902233-6280-1-git-send-email-yamada.m@jp.panasonic.com (mailing list archive)
State New, archived
Headers show

Commit Message

Masahiro Yamada Dec. 13, 2013, 2:37 a.m. UTC
We have the definition of "comma" in scripts/Kbuild.include.
We should not double it.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
 arch/arm/Makefile   | 2 --
 arch/arm64/Makefile | 2 --
 2 files changed, 4 deletions(-)

Comments

Masahiro Yamada March 28, 2014, 7:05 a.m. UTC | #1
Hi Michal,

Does this patch look good?
Any problem? Or should I have sent it to arm-kernel, not linux-kbuild ML?

Thanks.

Masahiro Yamada



On Fri, 13 Dec 2013 11:37:13 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:

> We have the definition of "comma" in scripts/Kbuild.include.
> We should not double it.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>  arch/arm/Makefile   | 2 --
>  arch/arm64/Makefile | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index db50b62..60351d2 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -53,8 +53,6 @@ AS		+= -EL
>  LD		+= -EL
>  endif
>  
> -comma = ,
> -
>  # This selects which instruction set is used.
>  # Note that GCC does not numerically define an architecture version
>  # macro, but instead defines a whole series of macros which makes
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index d90cf79..75c5527 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -24,8 +24,6 @@ KBUILD_CPPFLAGS	+= -mlittle-endian
>  AS		+= -EL
>  LD		+= -EL
>  
> -comma = ,
> -
>  CHECKFLAGS	+= -D__aarch64__
>  
>  # Default value
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michal Marek March 28, 2014, 10:15 a.m. UTC | #2
On 2014-03-28 08:05, Masahiro Yamada wrote:
> Hi Michal,
> 
> Does this patch look good?
> Any problem? Or should I have sent it to arm-kernel, not linux-kbuild ML?

Hi Masariho,

I'm sorry, I missed the patch. But it's indeed a better idea to send the
patch to linux-arm-kernel.

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index db50b62..60351d2 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -53,8 +53,6 @@  AS		+= -EL
 LD		+= -EL
 endif
 
-comma = ,
-
 # This selects which instruction set is used.
 # Note that GCC does not numerically define an architecture version
 # macro, but instead defines a whole series of macros which makes
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index d90cf79..75c5527 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -24,8 +24,6 @@  KBUILD_CPPFLAGS	+= -mlittle-endian
 AS		+= -EL
 LD		+= -EL
 
-comma = ,
-
 CHECKFLAGS	+= -D__aarch64__
 
 # Default value