From patchwork Sat Feb 8 07:50:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Kleen X-Patchwork-Id: 3609171 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F214BBF418 for ; Sat, 8 Feb 2014 07:51:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 336B320172 for ; Sat, 8 Feb 2014 07:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 582702017E for ; Sat, 8 Feb 2014 07:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbaBHHvc (ORCPT ); Sat, 8 Feb 2014 02:51:32 -0500 Received: from mga09.intel.com ([134.134.136.24]:13482 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbaBHHv2 (ORCPT ); Sat, 8 Feb 2014 02:51:28 -0500 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 07 Feb 2014 23:47:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,805,1384329600"; d="scan'208";a="480008251" Received: from laut.jf.intel.com (HELO localhost) ([10.23.232.94]) by orsmga002.jf.intel.com with ESMTP; 07 Feb 2014 23:51:24 -0800 Received: by localhost (Postfix, from userid 1000) id 627BB124AC1; Sat, 8 Feb 2014 08:50:46 +0100 (CET) From: Andi Kleen To: mmarek@suse.cz Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andi Kleen Subject: [PATCH 3/6] kbuild: Don't include const variable in kallsyms with !KALLSYMS_ALL Date: Sat, 8 Feb 2014 08:50:37 +0100 Message-Id: <1391845840-28514-3-git-send-email-ak@linux.intel.com> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1391845840-28514-1-git-send-email-ak@linux.intel.com> References: <1391845840-28514-1-git-send-email-ak@linux.intel.com> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP const variables are put into the text segment, so !KALLSYMS_ALL includes them into the kallsyms section. Remove them to make the kallsyms smaller. This also avoids some problems with LTO. The way LTO generates the first pass kallsyms cannot handle variables currently, so if we don't filter them out the first and second level pass differ too much. Signed-off-by: Andi Kleen --- scripts/kallsyms.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index ceef756..d79027e 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -151,6 +151,11 @@ static int read_symbol(FILE *in, struct sym_entry *s) /* exclude debugging symbols */ else if (stype == 'N') return -1; + /* Don't include const symbols in the text section + * unless --all-symbols is specified. + */ + else if (toupper(stype) != 'T' && !all_symbols) + return -1; /* include the type field in the symbol name, so that it gets * compressed together */