| Message ID | 1402019035-2190-1-git-send-email-yamada.m@jp.panasonic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 06, 2014 at 10:43:55AM +0900, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Michal, Reminder, just in case. If possible, please consider to include this patch in GIT-PULL. On Fri, 6 Jun 2014 15:30:23 +0200 Sam Ravnborg <sam@ravnborg.org> wrote: > On Fri, Jun 06, 2014 at 10:43:55AM +0900, Masahiro Yamada wrote: > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > Acked-by: Sam Ravnborg <sam@ravnborg.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dne 6.6.2014 03:43, Masahiro Yamada napsal(a): > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > --- > scripts/Makefile.clean | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean > index 686cb0d..a651cee 100644 > --- a/scripts/Makefile.clean > +++ b/scripts/Makefile.clean > @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn)) > # build a list of files to remove, usually relative to the current > # directory > > -__clean-files := $(extra-y) $(always) \ > - $(targets) $(clean-files) \ > +__clean-files := $(extra-y) $(extra-m) $(extra-) \ > + $(always) $(targets) $(clean-files) \ Do you have an example where generated files are left in the tree after make clean? This should go into the changelog. Dne 12.6.2014 07:46, Masahiro Yamada napsal(a):> Hi Michal, > If possible, please consider to include this patch in GIT-PULL. Sorry, I need to do a cut off at some point :). I'll merge it right after the merge window. If you provide a reproducer in the changelog, I'll send it to Linus for the next -rc. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Michal, > Dne 12.6.2014 07:46, Masahiro Yamada napsal(a):> Hi Michal, > > If possible, please consider to include this patch in GIT-PULL. > > Sorry, I need to do a cut off at some point :). I'll merge it right > after the merge window. If you provide a reproducer in the changelog, > I'll send it to Linus for the next -rc. > I understand. Sorry for bothering you when you are busy. Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dne 12.6.2014 10:40, Masahiro Yamada napsal(a): > Hi Michal, > > >> Dne 12.6.2014 07:46, Masahiro Yamada napsal(a):> Hi Michal, >>> If possible, please consider to include this patch in GIT-PULL. >> >> Sorry, I need to do a cut off at some point :). I'll merge it right >> after the merge window. If you provide a reproducer in the changelog, >> I'll send it to Linus for the next -rc. >> > > I understand. > Sorry for bothering you when you are busy. That's not a problem. It's more that Linus is usually not happy to see some last minute commits in the pull request. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dne 12.6.2014 10:24, Michal Marek napsal(a): > Dne 6.6.2014 03:43, Masahiro Yamada napsal(a): >> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> >> --- >> scripts/Makefile.clean | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean >> index 686cb0d..a651cee 100644 >> --- a/scripts/Makefile.clean >> +++ b/scripts/Makefile.clean >> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn)) >> # build a list of files to remove, usually relative to the current >> # directory >> >> -__clean-files := $(extra-y) $(always) \ >> - $(targets) $(clean-files) \ >> +__clean-files := $(extra-y) $(extra-m) $(extra-) \ >> + $(always) $(targets) $(clean-files) \ > > Do you have an example where generated files are left in the tree after > make clean? This should go into the changelog. Hi Masahiro, do you have a reproducer, i.e. an example where make clean leaves generated files in the tree? Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Michal, On Wed, 18 Jun 2014 21:53:02 +0200 Michal Marek <mmarek@suse.cz> wrote: > Dne 12.6.2014 10:24, Michal Marek napsal(a): > > Dne 6.6.2014 03:43, Masahiro Yamada napsal(a): > >> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > >> --- > >> scripts/Makefile.clean | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean > >> index 686cb0d..a651cee 100644 > >> --- a/scripts/Makefile.clean > >> +++ b/scripts/Makefile.clean > >> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn)) > >> # build a list of files to remove, usually relative to the current > >> # directory > >> > >> -__clean-files := $(extra-y) $(always) \ > >> - $(targets) $(clean-files) \ > >> +__clean-files := $(extra-y) $(extra-m) $(extra-) \ > >> + $(always) $(targets) $(clean-files) \ > > > > Do you have an example where generated files are left in the tree after > > make clean? This should go into the changelog. > > Hi Masahiro, > > do you have a reproducer, i.e. an example where make clean leaves > generated files in the tree? No, I don't. I thought arch/powerpc/kernel/Makefile is using extra-$(CONFIG_...) += ... but *.o files are simply cleaned-up. So this isn't the case. Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dne 20.6.2014 14:22, Masahiro Yamada napsal(a): > Hi Michal, > > > On Wed, 18 Jun 2014 21:53:02 +0200 > Michal Marek <mmarek@suse.cz> wrote: > >> Dne 12.6.2014 10:24, Michal Marek napsal(a): >>> Dne 6.6.2014 03:43, Masahiro Yamada napsal(a): >>>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> >>>> --- >>>> scripts/Makefile.clean | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean >>>> index 686cb0d..a651cee 100644 >>>> --- a/scripts/Makefile.clean >>>> +++ b/scripts/Makefile.clean >>>> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn)) >>>> # build a list of files to remove, usually relative to the current >>>> # directory >>>> >>>> -__clean-files := $(extra-y) $(always) \ >>>> - $(targets) $(clean-files) \ >>>> +__clean-files := $(extra-y) $(extra-m) $(extra-) \ >>>> + $(always) $(targets) $(clean-files) \ >>> >>> Do you have an example where generated files are left in the tree after >>> make clean? This should go into the changelog. >> >> Hi Masahiro, >> >> do you have a reproducer, i.e. an example where make clean leaves >> generated files in the tree? > > No, I don't. > > I thought > arch/powerpc/kernel/Makefile is using > extra-$(CONFIG_...) += ... > but *.o files are simply cleaned-up. So this isn't the case. OK, so there is no urgent need to add this to 'rc-fixes'. I'll queue it up in 'kbuild' for 3.17-rc1. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dne 20.6.2014 15:23, Michal Marek napsal(a): > Dne 20.6.2014 14:22, Masahiro Yamada napsal(a): >> Hi Michal, >> >> >> On Wed, 18 Jun 2014 21:53:02 +0200 >> Michal Marek <mmarek@suse.cz> wrote: >> >>> Dne 12.6.2014 10:24, Michal Marek napsal(a): >>>> Dne 6.6.2014 03:43, Masahiro Yamada napsal(a): >>>>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> >>>>> --- >>>>> scripts/Makefile.clean | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean >>>>> index 686cb0d..a651cee 100644 >>>>> --- a/scripts/Makefile.clean >>>>> +++ b/scripts/Makefile.clean >>>>> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn)) >>>>> # build a list of files to remove, usually relative to the current >>>>> # directory >>>>> >>>>> -__clean-files := $(extra-y) $(always) \ >>>>> - $(targets) $(clean-files) \ >>>>> +__clean-files := $(extra-y) $(extra-m) $(extra-) \ >>>>> + $(always) $(targets) $(clean-files) \ >>>> >>>> Do you have an example where generated files are left in the tree after >>>> make clean? This should go into the changelog. >>> >>> Hi Masahiro, >>> >>> do you have a reproducer, i.e. an example where make clean leaves >>> generated files in the tree? >> >> No, I don't. >> >> I thought >> arch/powerpc/kernel/Makefile is using >> extra-$(CONFIG_...) += ... >> but *.o files are simply cleaned-up. So this isn't the case. > > OK, so there is no urgent need to add this to 'rc-fixes'. I'll queue it > up in 'kbuild' for 3.17-rc1. It's in kbuild.git#kbuild now. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean index 686cb0d..a651cee 100644 --- a/scripts/Makefile.clean +++ b/scripts/Makefile.clean @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn)) # build a list of files to remove, usually relative to the current # directory -__clean-files := $(extra-y) $(always) \ - $(targets) $(clean-files) \ +__clean-files := $(extra-y) $(extra-m) $(extra-) \ + $(always) $(targets) $(clean-files) \ $(host-progs) \ $(hostprogs-y) $(hostprogs-m) $(hostprogs-)
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> --- scripts/Makefile.clean | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)