From patchwork Fri Jan 2 20:39:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 5560851 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7FCC19F2ED for ; Fri, 2 Jan 2015 20:39:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 831F720220 for ; Fri, 2 Jan 2015 20:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8993A2021B for ; Fri, 2 Jan 2015 20:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbbABUj0 (ORCPT ); Fri, 2 Jan 2015 15:39:26 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:32776 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbbABUjZ (ORCPT ); Fri, 2 Jan 2015 15:39:25 -0500 Received: by mail-wg0-f48.google.com with SMTP id y19so24487836wgg.21 for ; Fri, 02 Jan 2015 12:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=a7TETFEL8f3J9lEq4MEcdmiHiB/QdTKBClY9zsiNPVA=; b=sF1IGqiVBdkuv3YQ7cAN7fIKEhv0qAi5LFVlGbrxpljI9LaMSKNZBFQvUZJ2VFIwsb xBu8SjaIeRvd+w7NmTHff3gJJK+iv+7vy35Mr0o3r2V9XnJqcG9QzZBFR7Bveu2wY3Ch cl6hJuy364l5ldWyPTPAocdHKQ399VdK6FXxyPAT3SWRRIDqVOdzWD8BD0iGCX2qeoG1 OnXehLSPazdSCi7rU7rMF7ol4oivW8AynDdY++MkIZHszj665GzxS8r3xRciNmt8BCtW 4EpgQm93+CrLLtj/T/WDOy4MjL3l01er4Py7WiDMoqXGfk9mNy0Lxg57WAbiiQf8SPG/ wo1g== X-Received: by 10.180.221.72 with SMTP id qc8mr946071wic.19.1420231164342; Fri, 02 Jan 2015 12:39:24 -0800 (PST) Received: from fambox.fambox-domain ([46.115.21.76]) by mx.google.com with ESMTPSA id gb10sm40590525wjb.21.2015.01.02.12.39.18 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 02 Jan 2015 12:39:23 -0800 (PST) From: Sedat Dilek Cc: Sedat Dilek , Ben Hutchings , maximilian attems , Thorsten Glaser , Alexander Wirt , Michal Marek , linux-kbuild@vger.kernel.org Subject: [RFC v2] builddeb: Try to determine distribution Date: Fri, 2 Jan 2015 21:39:09 +0100 Message-Id: <1420231149-7425-1-git-send-email-sedat.dilek@gmail.com> X-Mailer: git-send-email 2.2.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is based on ideas of me and Ben. Thanks goes to Thorsten and Alexander for the vital help in 2012. Also Thanks to maximilian for the review of my diverse patches. Like in my initial patch [1] lsb_release is used to determine the short codename as distribution name for debian/changelog. Ben gave some helpful and detailed information in [2]. There he also suggested to have an option to explicitly set the distribution (see $KDEB_CHANGELOG_DIST variable). I have hardcoded the script-name when the default distribution is used. This is a bit ugly. This patch is based on the snippet of Ben in [2] and tested against Linux v3.19-rc2. [1] https://lkml.org/lkml/2012/4/23/516 [2] http://marc.info/?l=linux-kbuild&m=142022188322321&w=2 CC: Ben Hutchings CC: maximilian attems CC: Thorsten Glaser CC: Alexander Wirt CC: Michal Marek CC: linux-kbuild@vger.kernel.org Suggested-by: Ben Hutchings Signed-off-by: Sedat Dilek --- v2: Suppress error messages when lsb_release is not installed. (Thanks maximilian and Ben.) scripts/package/builddeb | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index 5972624..6918429 100755 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -217,9 +217,21 @@ else fi maintainer="$name <$email>" +# Try to determine distribution +codename=$(lsb_release --codename --short 2> /dev/null) +if [ -n "$KDEB_CHANGELOG_DIST" ]; then + distribution=$KDEB_CHANGELOG_DIST +elif [ -n "$codename" ]; then + distribution=$codename +else + distribution="unstable" + echo "builddeb: Using default distribution of 'unstable' in the changelog" + echo "builddeb: Install lsb-release or set \$KDEB_CHANGELOG_DIST to change this" +fi + # Generate a simple changelog template cat < debian/changelog -linux-upstream ($packageversion) unstable; urgency=low +linux-upstream ($packageversion) $distribution; urgency=low * Custom built Linux kernel.