| Message ID | 1432640395-17310-2-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello, Can you please include a minor change in your patch? At line 89, there's this: # on its behavior(sets new symbols to their default value but not 'n') with the Please change this line to this: # on its behavior (sets new symbols to their default value but not 'n') with the There should be a space between "behavior" and the parentheses/bracket. Thanks, Diego On Tue, May 26, 2015 at 8:39 AM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Some "make help" text lines extend beyond 80 characters. Wrap them at 79 > characters. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > scripts/kconfig/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > index d9b1fef0c67e3cb4..d19de3665bfbe984 100644 > --- a/scripts/kconfig/Makefile > +++ b/scripts/kconfig/Makefile > @@ -122,7 +122,8 @@ tinyconfig: > # Help text used by make help > help: > @echo ' config - Update current config utilising a line-oriented program' > - @echo ' nconfig - Update current config utilising a ncurses menu based program' > + @echo ' nconfig - Update current config utilising a ncurses menu based' > + @echo ' program' > @echo ' menuconfig - Update current config utilising a menu based program' > @echo ' xconfig - Update current config utilising a QT based front-end' > @echo ' gconfig - Update current config utilising a GTK based front-end' > @@ -138,7 +139,8 @@ help: > @echo ' alldefconfig - New config with all symbols set to default' > @echo ' randconfig - New config with random answer to all options' > @echo ' listnewconfig - List new options' > - @echo ' olddefconfig - Same as silentoldconfig but sets new symbols to their default value' > + @echo ' olddefconfig - Same as silentoldconfig but sets new symbols to their' > + @echo ' default value' > @echo ' kvmconfig - Enable additional options for guest kernel support' > @echo ' tinyconfig - Configure the tiniest possible kernel' > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, May 31, 2015 at 3:10 AM, Diego Viola <diego.viola@gmail.com> wrote: > Can you please include a minor change in your patch? > > At line 89, there's this: > > # on its behavior(sets new symbols to their default value but not 'n') with the > > Please change this line to this: > > # on its behavior (sets new symbols to their default value but not 'n') with the > > There should be a space between "behavior" and the parentheses/bracket. That's an unrelated change in an unrelated part of my patch. Please send a separate patch to fix that. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Okay, will do. Diego On Sun, May 31, 2015 at 5:26 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Sun, May 31, 2015 at 3:10 AM, Diego Viola <diego.viola@gmail.com> wrote: >> Can you please include a minor change in your patch? >> >> At line 89, there's this: >> >> # on its behavior(sets new symbols to their default value but not 'n') with the >> >> Please change this line to this: >> >> # on its behavior (sets new symbols to their default value but not 'n') with the >> >> There should be a space between "behavior" and the parentheses/bracket. > > That's an unrelated change in an unrelated part of my patch. > > Please send a separate patch to fix that. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Done. On Sun, May 31, 2015 at 9:53 AM, Diego Viola <diego.viola@gmail.com> wrote: > Okay, will do. > > Diego > > On Sun, May 31, 2015 at 5:26 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> On Sun, May 31, 2015 at 3:10 AM, Diego Viola <diego.viola@gmail.com> wrote: >>> Can you please include a minor change in your patch? >>> >>> At line 89, there's this: >>> >>> # on its behavior(sets new symbols to their default value but not 'n') with the >>> >>> Please change this line to this: >>> >>> # on its behavior (sets new symbols to their default value but not 'n') with the >>> >>> There should be a space between "behavior" and the parentheses/bracket. >> >> That's an unrelated change in an unrelated part of my patch. >> >> Please send a separate patch to fix that. >> >> Gr{oetje,eeting}s, >> >> Geert >> >> -- >> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org >> >> In personal conversations with technical people, I call myself a hacker. But >> when I'm talking to journalists I just say "programmer" or something like that. >> -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 26, 2015 at 01:39:54PM +0200, Geert Uytterhoeven wrote: > Some "make help" text lines extend beyond 80 characters. Wrap them at 79 > characters. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied to kbuild.git#kconfig. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index d9b1fef0c67e3cb4..d19de3665bfbe984 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -122,7 +122,8 @@ tinyconfig: # Help text used by make help help: @echo ' config - Update current config utilising a line-oriented program' - @echo ' nconfig - Update current config utilising a ncurses menu based program' + @echo ' nconfig - Update current config utilising a ncurses menu based' + @echo ' program' @echo ' menuconfig - Update current config utilising a menu based program' @echo ' xconfig - Update current config utilising a QT based front-end' @echo ' gconfig - Update current config utilising a GTK based front-end' @@ -138,7 +139,8 @@ help: @echo ' alldefconfig - New config with all symbols set to default' @echo ' randconfig - New config with random answer to all options' @echo ' listnewconfig - List new options' - @echo ' olddefconfig - Same as silentoldconfig but sets new symbols to their default value' + @echo ' olddefconfig - Same as silentoldconfig but sets new symbols to their' + @echo ' default value' @echo ' kvmconfig - Enable additional options for guest kernel support' @echo ' tinyconfig - Configure the tiniest possible kernel'
Some "make help" text lines extend beyond 80 characters. Wrap them at 79 characters. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- scripts/kconfig/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)