diff mbox

Makefile: .PHONY is not a variable, but PHONY is

Message ID 1441199479-12576-1-git-send-email-ulfalizer.lkml@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ulf Magnusson Sept. 2, 2015, 1:11 p.m. UTC 
From: Ulf Magnusson <ulfalizer@gmail.com>

.PHONY is a target, not a variable.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada Dec. 7, 2017, 3:03 p.m. UTC | #1 
Hi Ulf,




2015-09-02 22:11 GMT+09:00  <ulfalizer.lkml@gmail.com>:
> From: Ulf Magnusson <ulfalizer@gmail.com>
>
> .PHONY is a target, not a variable.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 24c9e3d..4835d24 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1609,6 +1609,6 @@ endif     # skip-makefile
>  PHONY += FORCE
>  FORCE:
>
> -# Declare the contents of the .PHONY variable as phony.  We keep that
> +# Declare the contents of the PHONY variable as phony.  We keep that
>  # information in a variable so we can use it in if_changed and friends.
>  .PHONY: $(PHONY)
> --


I found this patch by chance.


Can you fix other files in scripts/ as well?

I see the same pattern in

Makefile.build
Makefile.clean
Makefile.modbuiltin
Makefile.modinst
Makefile.modpost
Makefile.modsign

Then, I will apply it quickly.
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 24c9e3d..4835d24 100644
--- a/Makefile
+++ b/Makefile
@@ -1609,6 +1609,6 @@  endif	# skip-makefile
 PHONY += FORCE
 FORCE:
 
-# Declare the contents of the .PHONY variable as phony.  We keep that
+# Declare the contents of the PHONY variable as phony.  We keep that
 # information in a variable so we can use it in if_changed and friends.
 .PHONY: $(PHONY)