| Message ID | 168b2cb09f09ec3cead8a6b1e726ac76f5d06171.1733820553.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kbuild: Drop architecture argument from headers_check.pl | expand |
On Tue, Dec 10, 2024 at 5:52 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > Since commit 7ff0fd4a9e20cf73 ("kbuild: drop support for This is not a fixed commit hash because Andrew Morton does not use 'git request-pull' I will squash this to the original patch. > include/asm-<arch> in headers_check.pl"), the second argument $arch is > no longer used, hence drop it. > > Reported-by: Masahiro Yamada <masahiroy@kernel.org> > Closes: https://lore.kernel.org/CAK7LNARNa3NPSeRAUgMaEqWiA+C6-s1PxRe1bCUJg6zLyOtDkA@mail.gmail.com > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Commit 7ff0fd4a9e20cf73 is part of the mm tree. > > usr/include/Makefile | 2 +- > usr/include/headers_check.pl | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/usr/include/Makefile b/usr/include/Makefile > index 771e32872b2ab12d..6c6de1b1622b1a69 100644 > --- a/usr/include/Makefile > +++ b/usr/include/Makefile > @@ -78,7 +78,7 @@ quiet_cmd_hdrtest = HDRTEST $< > cmd_hdrtest = \ > $(CC) $(c_flags) -fsyntax-only -x c /dev/null \ > $(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \ > - $(PERL) $(src)/headers_check.pl $(obj) $(SRCARCH) $<; \ > + $(PERL) $(src)/headers_check.pl $(obj) $<; \ > touch $@ > > $(obj)/%.hdrtest: $(obj)/%.h FORCE > diff --git a/usr/include/headers_check.pl b/usr/include/headers_check.pl > index 7070c891ea294b4d..2b70bfa5558e6451 100755 > --- a/usr/include/headers_check.pl > +++ b/usr/include/headers_check.pl > @@ -3,9 +3,8 @@ > # > # headers_check.pl execute a number of trivial consistency checks > # > -# Usage: headers_check.pl dir arch [files...] > +# Usage: headers_check.pl dir [files...] > # dir: dir to look for included files > -# arch: architecture > # files: list of files to check > # > # The script reads the supplied files line by line and: > @@ -23,7 +22,7 @@ use warnings; > use strict; > use File::Basename; > > -my ($dir, $arch, @files) = @ARGV; > +my ($dir, @files) = @ARGV; > > my $ret = 0; > my $line; > -- > 2.34.1 >
Hi Yamada-san, On Tue, Dec 10, 2024 at 11:14 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > On Tue, Dec 10, 2024 at 5:52 PM Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > > > > Since commit 7ff0fd4a9e20cf73 ("kbuild: drop support for > > This is not a fixed commit hash because Andrew Morton > does not use 'git request-pull' > > I will squash this to the original patch. Thank you! Gr{oetje,eeting}s, Geert
diff --git a/usr/include/Makefile b/usr/include/Makefile index 771e32872b2ab12d..6c6de1b1622b1a69 100644 --- a/usr/include/Makefile +++ b/usr/include/Makefile @@ -78,7 +78,7 @@ quiet_cmd_hdrtest = HDRTEST $< cmd_hdrtest = \ $(CC) $(c_flags) -fsyntax-only -x c /dev/null \ $(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \ - $(PERL) $(src)/headers_check.pl $(obj) $(SRCARCH) $<; \ + $(PERL) $(src)/headers_check.pl $(obj) $<; \ touch $@ $(obj)/%.hdrtest: $(obj)/%.h FORCE diff --git a/usr/include/headers_check.pl b/usr/include/headers_check.pl index 7070c891ea294b4d..2b70bfa5558e6451 100755 --- a/usr/include/headers_check.pl +++ b/usr/include/headers_check.pl @@ -3,9 +3,8 @@ # # headers_check.pl execute a number of trivial consistency checks # -# Usage: headers_check.pl dir arch [files...] +# Usage: headers_check.pl dir [files...] # dir: dir to look for included files -# arch: architecture # files: list of files to check # # The script reads the supplied files line by line and: @@ -23,7 +22,7 @@ use warnings; use strict; use File::Basename; -my ($dir, $arch, @files) = @ARGV; +my ($dir, @files) = @ARGV; my $ret = 0; my $line;
Since commit 7ff0fd4a9e20cf73 ("kbuild: drop support for include/asm-<arch> in headers_check.pl"), the second argument $arch is no longer used, hence drop it. Reported-by: Masahiro Yamada <masahiroy@kernel.org> Closes: https://lore.kernel.org/CAK7LNARNa3NPSeRAUgMaEqWiA+C6-s1PxRe1bCUJg6zLyOtDkA@mail.gmail.com Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Commit 7ff0fd4a9e20cf73 is part of the mm tree. usr/include/Makefile | 2 +- usr/include/headers_check.pl | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)