From patchwork Mon Sep 14 21:49:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 47484 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8ELnCsc032334 for ; Mon, 14 Sep 2009 21:49:27 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755854AbZINVtW (ORCPT ); Mon, 14 Sep 2009 17:49:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756117AbZINVtW (ORCPT ); Mon, 14 Sep 2009 17:49:22 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51896 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755581AbZINVtW (ORCPT ); Mon, 14 Sep 2009 17:49:22 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n8ELn6bg022471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Sep 2009 14:49:07 -0700 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id n8ELn6W2018518; Mon, 14 Sep 2009 14:49:06 -0700 Message-Id: <200909142149.n8ELn6W2018518@imap1.linux-foundation.org> Subject: [patch 05/18] checkincludes.pl: close file as soon as we're done with it To: sam@ravnborg.org Cc: linux-kbuild@vger.kernel.org, akpm@linux-foundation.org, lrodriguez@Atheros.com, lrodriguez@Atheros.com From: akpm@linux-foundation.org Date: Mon, 14 Sep 2009 14:49:06 -0700 MIME-Version: 1.0 X-Spam-Status: No, hits=-3.512 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org From: "Luis R. Rodriguez" Signed-off-by: Luis R. Rodriguez Cc: Sam Ravnborg Signed-off-by: Andrew Morton --- scripts/checkincludes.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN scripts/checkincludes.pl~checkincludespl-close-file-as-soon-as-were-done-with-it scripts/checkincludes.pl --- a/scripts/checkincludes.pl~checkincludespl-close-file-as-soon-as-were-done-with-it +++ a/scripts/checkincludes.pl @@ -13,12 +13,12 @@ foreach $file (@ARGV) { ++$includedfiles{$1}; } } + + close(FILE); foreach $filename (keys %includedfiles) { if ($includedfiles{$filename} > 1) { print "$file: $filename is included more than once.\n"; } } - - close(FILE); }