| Message ID | 20090925231601.GB28714@progeny.tock (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/scripts/package/Makefile b/scripts/package/Makefile index a5d9088..260e3e6 100644 --- a/scripts/package/Makefile +++ b/scripts/package/Makefile @@ -1,6 +1,15 @@ # Makefile for the different targets used to generate full packages of a kernel # It uses the generic clean infrastructure of kbuild +# How to acquire (fake) root privileges +ifndef ROOTCMD +ifneq ($(shell id -u),0) +ifeq ($(shell which fakeroot >/dev/null 2>&1 && echo found),found) +ROOTCMD := fakeroot -u +endif +endif +endif + # RPM target # --------------------------------------------------------------------------- # The rpm target generates two rpm files:
Unless already running as root, use fakeroot to ensure the files in the generated binary packages are owned by root. Without this change, you have to set ROOTCMD or become root yourself to run "make foo-pkg". With this change, you can run "make oldconfig rpm-pkg" as an ordinary user to build a binary package for an updated kernel tree and it should just work. fakeroot is a bit too zealous by default in pretending files are owned by root: unless directed otherwise, its wrapped stat() and lstat() set st_uid and st_gid to 0 for all files. If CONFIG_LOCALVERSION_AUTO=y is set, git notices that the owners have changed and has to reread the entire kernel tree to discover that the version string does not need a "-dirty" suffix. But as long as "make install" and "scripts/package/foo" run within the same fakeroot invocation, it is perfectly safe to use the actual owner and group for preexisting files. Make it so by passing fakeroot the -u option. Note: if fakeroot is missing, all members of the package generated by "make tar-pkg" will be owned and writable by the invoking user, even once the archive is extracted. This is true even without this patch and probably should be addressed separately. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- Actually, this is all just an excuse to include a reminder about fakeroot -u in the kernel. :) But maybe it could be convenient for others, anyway. I look forward to your thoughts. Thanks, Jonathan scripts/package/Makefile | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)