From patchwork Thu Mar 11 22:05:14 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Andrew Morton <akpm@linux-foundation.org>
X-Patchwork-Id: 85121
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o2BM5Pjj023853
	for <patchwork-kbuild@patchwork.kernel.org>;
	Thu, 11 Mar 2010 22:05:36 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758254Ab0CKWFf (ORCPT
	<rfc822;patchwork-kbuild@patchwork.kernel.org>);
	Thu, 11 Mar 2010 17:05:35 -0500
Received: from smtp1.linux-foundation.org ([140.211.169.13]:60917 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758249Ab0CKWFf (ORCPT
	<rfc822;linux-kbuild@vger.kernel.org>);
	Thu, 11 Mar 2010 17:05:35 -0500
Received: from imap1.linux-foundation.org (imap1.linux-foundation.org
	[140.211.169.55])
	by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with
	ESMTP id o2BM5Enp013206
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 11 Mar 2010 14:05:15 -0800
Received: from localhost.localdomain (localhost [127.0.0.1])
	by imap1.linux-foundation.org
	(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id
	o2BM5ELf013286; Thu, 11 Mar 2010 14:05:14 -0800
Message-Id: <201003112205.o2BM5ELf013286@imap1.linux-foundation.org>
Subject: [patch 1/2] markup_oops: fix perlcritic warnings
To: mmarek@suse.cz
Cc: linux-kbuild@vger.kernel.org, akpm@linux-foundation.org,
	shemminger@vyatta.com, amwang@redhat.com, arjan@infradead.org
From: akpm@linux-foundation.org
Date: Thu, 11 Mar 2010 14:05:14 -0800
MIME-Version: 1.0
X-Spam-Status: No, hits=-3.516 required=5 tests=AWL, BAYES_00,
	OSDL_HEADER_SUBJECT_BRACKETED
X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__
X-MIMEDefang-Filter: lf$Revision: 1.188 $
X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13
Sender: linux-kbuild-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kbuild.vger.kernel.org>
X-Mailing-List: linux-kbuild@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]);
	Thu, 11 Mar 2010 22:05:36 +0000 (UTC)


diff -puN scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings scripts/markup_oops.pl
--- a/scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings
+++ a/scripts/markup_oops.pl
@@ -1,5 +1,7 @@
 #!/usr/bin/perl
 
+use strict;
+
 use File::Basename;
 use Math::BigInt;
 use Getopt::Long;
@@ -126,7 +128,7 @@ sub process_x86_regs
 		$clobber = "";
 	}
 
-	foreach $reg (keys(%regs)) {
+	foreach my $reg (keys(%regs)) {
 		my $clobberprime = reg_name($clobber);
 		my $lastwordprime = reg_name($lastword);
 		my $val = $regs{$reg};
@@ -263,7 +265,7 @@ while (<FILE>) {
 	}
 }
 
-close(FILE);
+close($file);
 
 if ($counter == 0) {
 	print "No matching code found \n";