[1/1] markup_oops: fix perlcritic warnings

Commit Message

Andrew Morton April 27, 2010, 9:12 p.m. UTC

None

Patch

diff -puN scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings scripts/markup_oops.pl
--- a/scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings
+++ a/scripts/markup_oops.pl
@@ -1,5 +1,7 @@ 
 #!/usr/bin/perl
 
+use strict;
+
 use File::Basename;
 use Math::BigInt;
 use Getopt::Long;
@@ -126,7 +128,7 @@  sub process_x86_regs
 		$clobber = "";
 	}
 
-	foreach $reg (keys(%regs)) {
+	foreach my $reg (keys(%regs)) {
 		my $clobberprime = reg_name($clobber);
 		my $lastwordprime = reg_name($lastword);
 		my $val = $regs{$reg};
@@ -263,7 +265,7 @@  while (<FILE>) {
 	}
 }
 
-close(FILE);
+close($file);
 
 if ($counter == 0) {
 	print "No matching code found \n";