From patchwork Sun Feb 20 19:39:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 576031 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1KJdBq0024490 for ; Sun, 20 Feb 2011 19:39:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750978Ab1BTTjL (ORCPT ); Sun, 20 Feb 2011 14:39:11 -0500 Received: from mail.skyhub.de ([78.46.96.112]:37660 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750906Ab1BTTjK (ORCPT ); Sun, 20 Feb 2011 14:39:10 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTP id C95861D9968; Sun, 20 Feb 2011 20:39:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1298230748; bh=R++d/OKnAoR9MjQJ2mvHouo7JlxTRi9tk0+dgQL1Zh4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=FkRCC5XmRgybvDfsJnHreBLr+PunV8nwlYSoa0 a2CC0c/OenoQsaxPvQnSQvqEbBQi+Vi/Is2u4lpKmeI6itRagRJLLMoLfU1egKjx5ZY so+NUZyp0bDAylhv8Oi+VRxIRP6/0tSFZGIllAK5CoxbCiTJ1jxc9xbTTpNMQ1cwl0= X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id E17ozwXiU0Q2; Sun, 20 Feb 2011 20:39:08 +0100 (CET) Received: from liondog.tnic (g229038177.adsl.alicedsl.de [92.229.38.177]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5735C1D9781; Sun, 20 Feb 2011 20:39:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1298230748; bh=R++d/OKnAoR9MjQJ2mvHouo7JlxTRi9tk0+dgQL1Zh4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=FkRCC5XmRgybvDfsJnHreBLr+PunV8nwlYSoa0 a2CC0c/OenoQsaxPvQnSQvqEbBQi+Vi/Is2u4lpKmeI6itRagRJLLMoLfU1egKjx5ZY so+NUZyp0bDAylhv8Oi+VRxIRP6/0tSFZGIllAK5CoxbCiTJ1jxc9xbTTpNMQ1cwl0= Received: by liondog.tnic (Postfix, from userid 1000) id 17DB54B880C; Sun, 20 Feb 2011 20:39:06 +0100 (CET) Date: Sun, 20 Feb 2011 20:39:06 +0100 From: Borislav Petkov To: Sam Ravnborg Cc: Michal Marek , torvalds@linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-kbuild@vger.kernel.org Subject: Re: [PATCH] kbuild: Add extra gcc checks Message-ID: <20110220193906.GC6713@liondog.tnic> Mail-Followup-To: Borislav Petkov , Sam Ravnborg , Michal Marek , torvalds@linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-kbuild@vger.kernel.org References: <1298219710-9846-1-git-send-email-bp@alien8.de> <20110220175709.GA5178@merkur.ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110220175709.GA5178@merkur.ravnborg.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 20 Feb 2011 19:39:12 +0000 (UTC) diff --git a/Makefile b/Makefile index c9c8c8f..03989a1 100644 --- a/Makefile +++ b/Makefile @@ -102,6 +102,15 @@ ifeq ("$(origin O)", "command line") KBUILD_OUTPUT := $(O) endif +ifeq ("$(origin W)", "command line") + KBUILD_ENABLE_EXTRA_GCC_CHECKS = 1 +endif +ifndef KBUILD_ENABLE_EXTRA_GCC_CHECKS + KBUILD_ENABLE_EXTRA_GCC_CHECKS = 0 +endif + +export KBUILD_ENABLE_EXTRA_GCC_CHECKS + # That's our default target when none is given on the command line PHONY := _all _all: @@ -1262,6 +1271,7 @@ help: @echo ' make O=dir [targets] Locate all output files in "dir", including .config' @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse by default)' @echo ' make C=2 [targets] Force check of all c source with $$CHECK' + @echo ' make W=1 [targets] Enable extra gcc checks' @echo '' @echo 'Execute "make" or "make all" to build all targets marked with [*] ' @echo 'For further info see the ./README file' diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 4eb99ab..5bf9f40 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -30,6 +30,33 @@ ldflags-y := subdir-asflags-y := subdir-ccflags-y := +# make W=1 settings +ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS +EXTRA_CFLAGS += -Wextra -Wno-unused +EXTRA_CFLAGS += -Waggregate-return +EXTRA_CFLAGS += -Wbad-function-cast +EXTRA_CFLAGS += -Wcast-qual +EXTRA_CFLAGS += -Wcast-align +EXTRA_CFLAGS += -Wconversion +EXTRA_CFLAGS += -Wdisabled-optimization +EXTRA_CFLAGS += -Wlogical-op +EXTRA_CFLAGS += -Wmissing-declarations +EXTRA_CFLAGS += -Wmissing-format-attribute +EXTRA_CFLAGS += -Wmissing-include-dirs +EXTRA_CFLAGS += -Wmissing-prototypes +EXTRA_CFLAGS += -Wnested-externs +EXTRA_CFLAGS += -Wold-style-definition +EXTRA_CFLAGS += -Woverlength-strings +EXTRA_CFLAGS += -Wpacked +EXTRA_CFLAGS += -Wpacked-bitfield-compat +EXTRA_CFLAGS += -Wpadded +EXTRA_CFLAGS += -Wpointer-arith +EXTRA_CFLAGS += -Wredundant-decls +EXTRA_CFLAGS += -Wshadow +EXTRA_CFLAGS += -Wswitch-default +EXTRA_CFLAGS += -Wvla +endif + # Read auto.conf if it exists, otherwise ignore -include include/config/auto.conf @@ -403,7 +430,6 @@ ifneq ($(cmd_files),) include $(cmd_files) endif - # Declare the contents of the .PHONY variable as phony. We keep that # information in a variable se we can use it in if_changed and friends.