From patchwork Mon Feb 21 02:23:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 576371 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1L2LMLl016664 for ; Mon, 21 Feb 2011 02:23:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755480Ab1BUCXY (ORCPT ); Sun, 20 Feb 2011 21:23:24 -0500 Received: from mail.skyhub.de ([78.46.96.112]:50090 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754994Ab1BUCXX (ORCPT ); Sun, 20 Feb 2011 21:23:23 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTP id 44B151D996C; Mon, 21 Feb 2011 03:23:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1298255000; bh=g+gT3fwiRkxAKygPya6V0FbYCfzm0H2p3tCXIaxHciU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=UVZjvXO9PmXIKQ7lpzQxWzp2HNj602H1L6EKGL 7IsoggP0qvcJrvToMXclgY5LGiNf3ZvvXmuFVB6unLUcPrXX8wT4g/gxfiq/bfM6gky 8R2N+K6iSEpKsvk1HMRwsnQPfHckmlA9mKVQV+nfRB/fI134RS7CQFDiIQkBwW8dDU= X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id a6KnDbDuDMXs; Mon, 21 Feb 2011 03:23:20 +0100 (CET) Received: from liondog.tnic (f053086097.adsl.alicedsl.de [78.53.86.97]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AE98C1D9968; Mon, 21 Feb 2011 03:23:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1298255000; bh=g+gT3fwiRkxAKygPya6V0FbYCfzm0H2p3tCXIaxHciU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=UVZjvXO9PmXIKQ7lpzQxWzp2HNj602H1L6EKGL 7IsoggP0qvcJrvToMXclgY5LGiNf3ZvvXmuFVB6unLUcPrXX8wT4g/gxfiq/bfM6gky 8R2N+K6iSEpKsvk1HMRwsnQPfHckmlA9mKVQV+nfRB/fI134RS7CQFDiIQkBwW8dDU= Received: by liondog.tnic (Postfix, from userid 1000) id 186114B880C; Mon, 21 Feb 2011 03:23:16 +0100 (CET) Date: Mon, 21 Feb 2011 03:23:16 +0100 From: Borislav Petkov To: Sam Ravnborg Cc: Michal Marek , torvalds@linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-kbuild@vger.kernel.org Subject: [PATCH -v3] kbuild: Add extra gcc checks Message-ID: <20110221022316.GA18332@liondog.tnic> Mail-Followup-To: Borislav Petkov , Sam Ravnborg , Michal Marek , torvalds@linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-kbuild@vger.kernel.org References: <1298219710-9846-1-git-send-email-bp@alien8.de> <20110220175709.GA5178@merkur.ravnborg.org> <20110220193906.GC6713@liondog.tnic> <20110220195222.GA12915@merkur.ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110220195222.GA12915@merkur.ravnborg.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 21 Feb 2011 02:23:25 +0000 (UTC) diff --git a/Makefile b/Makefile index c9c8c8f..c3bca9c 100644 --- a/Makefile +++ b/Makefile @@ -102,6 +102,11 @@ ifeq ("$(origin O)", "command line") KBUILD_OUTPUT := $(O) endif +ifeq ("$(origin W)", "command line") + KBUILD_ENABLE_EXTRA_GCC_CHECKS = 1 + export KBUILD_ENABLE_EXTRA_GCC_CHECKS +endif + # That's our default target when none is given on the command line PHONY := _all _all: @@ -1262,6 +1267,7 @@ help: @echo ' make O=dir [targets] Locate all output files in "dir", including .config' @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse by default)' @echo ' make C=2 [targets] Force check of all c source with $$CHECK' + @echo ' make W=1 [targets] Enable extra gcc checks' @echo '' @echo 'Execute "make" or "make all" to build all targets marked with [*] ' @echo 'For further info see the ./README file' diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 4eb99ab..b4d7661 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -49,6 +49,34 @@ ifeq ($(KBUILD_NOPEDANTIC),) $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use EXTRA_CFLAGS) endif endif + +# make W=1 settings +ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS +KBUILD_CFLAGS += -Wextra -Wno-unused +KBUILD_CFLAGS += -Waggregate-return +KBUILD_CFLAGS += -Wbad-function-cast +KBUILD_CFLAGS += -Wcast-qual +KBUILD_CFLAGS += -Wcast-align +KBUILD_CFLAGS += -Wconversion +KBUILD_CFLAGS += -Wdisabled-optimization +KBUILD_CFLAGS += -Wlogical-op +KBUILD_CFLAGS += -Wmissing-declarations +KBUILD_CFLAGS += -Wmissing-format-attribute +KBUILD_CFLAGS += -Wmissing-include-dirs +KBUILD_CFLAGS += -Wmissing-prototypes +KBUILD_CFLAGS += -Wnested-externs +KBUILD_CFLAGS += -Wold-style-definition +KBUILD_CFLAGS += -Woverlength-strings +KBUILD_CFLAGS += -Wpacked +KBUILD_CFLAGS += -Wpacked-bitfield-compat +KBUILD_CFLAGS += -Wpadded +KBUILD_CFLAGS += -Wpointer-arith +KBUILD_CFLAGS += -Wredundant-decls +KBUILD_CFLAGS += -Wshadow +KBUILD_CFLAGS += -Wswitch-default +KBUILD_CFLAGS += -Wvla +endif + include scripts/Makefile.lib ifdef host-progs @@ -403,7 +431,6 @@ ifneq ($(cmd_files),) include $(cmd_files) endif - # Declare the contents of the .PHONY variable as phony. We keep that # information in a variable se we can use it in if_changed and friends.