From patchwork Sun Dec 2 16:35:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wang yanqing X-Patchwork-Id: 1831071 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 495F5402E1 for ; Sun, 2 Dec 2012 16:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753931Ab2LBQew (ORCPT ); Sun, 2 Dec 2012 11:34:52 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33726 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528Ab2LBQev (ORCPT ); Sun, 2 Dec 2012 11:34:51 -0500 Received: by mail-pa0-f46.google.com with SMTP id bh2so1376477pad.19 for ; Sun, 02 Dec 2012 08:34:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; bh=VTCsZKcBIhC5DaU6QkPCMlwDCT3QdcCUJ3ysEExSPQM=; b=oZXdzpvFGccacIQLqX8HQgAMSUYWVjLSec+qB1hNJz4qWmpT88dfBzMX+hgG1uJeDX c75uzt9Z30sgCf+sn44uYtiEmrNqX3gChQfpPCzVHVtn2yMfcyCyoxMs6QYliOevPsY/ LVjYDYJly8fXA1rUndRaEaHP8SUB3i5C0RsyVvUDIvce5ctmsHnyvPcta6tQO0d4wXTJ oW/gURNMU8YrW4ihAioJX7CEaD7wM3vmEl3rbsadVpzhlKV57agjtbFk6Y84zaVVcgyT C7CTETQf81uDhHp0XN9VOF7pm4VlxV7irlMW4aQEztxdMu551kcwJ9vw8fz9gGl8qQdN x5ZQ== Received: by 10.66.78.169 with SMTP id c9mr19213575pax.30.1354466091040; Sun, 02 Dec 2012 08:34:51 -0800 (PST) Received: from udknight.localhost ([110.87.76.217]) by mx.google.com with ESMTPS id sk1sm5292446pbc.0.2012.12.02.08.34.44 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 02 Dec 2012 08:34:49 -0800 (PST) Received: from udknight.localhost (udknight.localhost [127.0.0.1]) by udknight.localhost (8.14.4/8.14.4) with ESMTP id qB2GZCBh020863; Mon, 3 Dec 2012 00:35:12 +0800 Received: (from root@localhost) by udknight.localhost (8.14.4/8.14.4/Submit) id qB2GZ9um020859; Mon, 3 Dec 2012 00:35:09 +0800 Date: Mon, 3 Dec 2012 00:35:09 +0800 From: Wang YanQing To: mmarek@suse.cz Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net, bp@alien8.de, yann.morin.1998@free.fr, sakiwit@gmail.com, lacombar@gmail.com, lucas.demarchi@profusion.mobi, dave@gnu.org, paul.gortmaker@windriver.com, crquan@gmail.com, bpoirier@suse.de Subject: [PATCH] lxdialog:inputbox: Fix can't change selected button with Left/Right when input box selected Message-ID: <20121202163509.GB20796@udknight> Mail-Followup-To: Wang YanQing , mmarek@suse.cz, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net, bp@alien8.de, yann.morin.1998@free.fr, sakiwit@gmail.com, lacombar@gmail.com, lucas.demarchi@profusion.mobi, dave@gnu.org, paul.gortmaker@windriver.com, crquan@gmail.com, bpoirier@suse.de MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org inputbox code don't support use Left/Right to change input position in the input box, so it use continue to skip them when input key is Left/Right, but use break for Up/Down, so we can change selected button with Up/Down but we can't do it with Left/Right key when input box selected. This patch fix it. Signed-off-by: Wang YanQing --- scripts/kconfig/lxdialog/inputbox.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/kconfig/lxdialog/inputbox.c b/scripts/kconfig/lxdialog/inputbox.c index dd8e587..7841f46 100644 --- a/scripts/kconfig/lxdialog/inputbox.c +++ b/scripts/kconfig/lxdialog/inputbox.c @@ -120,11 +120,9 @@ do_resize: case TAB: case KEY_UP: case KEY_DOWN: - break; case KEY_LEFT: - continue; case KEY_RIGHT: - continue; + break; case KEY_BACKSPACE: case 127: if (input_x || scroll) {