From patchwork Sun Dec 9 16:54:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Marek X-Patchwork-Id: 1853831 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 53AE8DF230 for ; Sun, 9 Dec 2012 16:54:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756732Ab2LIQy3 (ORCPT ); Sun, 9 Dec 2012 11:54:29 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44726 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756731Ab2LIQy3 (ORCPT ); Sun, 9 Dec 2012 11:54:29 -0500 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id EAF01A3A4A; Sun, 9 Dec 2012 17:54:26 +0100 (CET) Received: by pobox.suse.cz (Postfix, from userid 10020) id A7859C22A4; Sun, 9 Dec 2012 17:54:25 +0100 (CET) Date: Sun, 9 Dec 2012 17:54:25 +0100 From: Michal Marek To: pefoley2@verizon.net, David Howells , Rusty Russell Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH 2/5] kbuild: silence rule for extra_certificates Message-ID: <20121209165425.GA29331@pobox.suse.cz> References: <1353269117-39917-1-git-send-email-pefoley2@verizon.net> <1353269117-39917-2-git-send-email-pefoley2@verizon.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1353269117-39917-2-git-send-email-pefoley2@verizon.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Added David and Rusty. On Sun, Nov 18, 2012 at 03:05:14PM -0500, pefoley2@verizon.net wrote: > From: Peter Foley > > Silence the touch extra_certificates command > > Signed-off-by: Peter Foley I think we should tell the user that the default empty extra certificates list is being used, in case the user used a wrong filename or similar. How about this? Subject: MODSIGN: Fix kbuild output when using default extra_certificates Signed-off-by: Michal Marek But I don't insist on the above, feel free to hide the command completely. Michal > --- > kernel/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/Makefile b/kernel/Makefile > index 86e3285..18a0b61 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -137,7 +137,7 @@ ifeq ($(CONFIG_MODULE_SIG),y) > # Pull the signing certificate and any extra certificates into the kernel > # > extra_certificates: > - touch $@ > + @touch $@ > > kernel/modsign_pubkey.o: signing_key.x509 extra_certificates > > -- > 1.8.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/Makefile b/kernel/Makefile index 0dfeca4..8c708e4 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -136,8 +136,12 @@ ifeq ($(CONFIG_MODULE_SIG),y) # # Pull the signing certificate and any extra certificates into the kernel # + +quiet_cmd_touch = TOUCH $@ + cmd_touch = touch $@ + extra_certificates: - touch $@ + $(call cmd,touch) kernel/modsign_pubkey.o: signing_key.x509 extra_certificates