From patchwork Tue Dec 18 20:31:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 1893561 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 750FE3FCD4 for ; Tue, 18 Dec 2012 20:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754422Ab2LRUcE (ORCPT ); Tue, 18 Dec 2012 15:32:04 -0500 Received: from mail.skyhub.de ([78.46.96.112]:43651 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389Ab2LRUcD (ORCPT ); Tue, 18 Dec 2012 15:32:03 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1355862720; bh=Kj49gflh5Blovv1/l2gxusg8chlc7uHbvPKmIygPaIc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=hoJ5KIvdfdKUMNYIvErS4bUaVZSZEc4DV5BOLI WprV8X8jHQBwWxvEhXNA0xamtYyweRx0JuO9uLVUDYQ3KjqK7xmacEcIdoqMwMAPkzB lUECwVRLWCnQUzdXfGYINoUtDkEFSLuSNmddd0MqGA6WuT9OuoeeM+tRBkSFep+bOw= Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UvZycRjf67dF; Tue, 18 Dec 2012 21:32:00 +0100 (CET) Received: from liondog.tnic (p4FF1D4E2.dip.t-dialin.net [79.241.212.226]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5BDAA1D9CF2; Tue, 18 Dec 2012 21:32:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1355862720; bh=Kj49gflh5Blovv1/l2gxusg8chlc7uHbvPKmIygPaIc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=hoJ5KIvdfdKUMNYIvErS4bUaVZSZEc4DV5BOLI WprV8X8jHQBwWxvEhXNA0xamtYyweRx0JuO9uLVUDYQ3KjqK7xmacEcIdoqMwMAPkzB lUECwVRLWCnQUzdXfGYINoUtDkEFSLuSNmddd0MqGA6WuT9OuoeeM+tRBkSFep+bOw= Received: by liondog.tnic (Postfix, from userid 1000) id B6DFA4B8A0F; Tue, 18 Dec 2012 21:31:59 +0100 (CET) Date: Tue, 18 Dec 2012 21:31:59 +0100 From: Borislav Petkov To: Joe Perches Cc: Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells Subject: Re: [PATCH] scripts: add checkmaintainers.py Message-ID: <20121218203159.GI31255@liondog.tnic> Mail-Followup-To: Borislav Petkov , Joe Perches , Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells References: <1355523576-7596-1-git-send-email-cesarb@cesarb.net> <50CEF080.8010208@suse.cz> <20121217102714.GB31947@liondog.tnic> <1355758544.13361.14.camel@joe-AO722> <20121217170011.GC31866@liondog.tnic> <1355770579.13361.41.camel@joe-AO722> <1355771383.13361.44.camel@joe-AO722> <20121218182838.GF31255@liondog.tnic> <1355859281.30366.29.camel@joe-AO722> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1355859281.30366.29.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Tue, Dec 18, 2012 at 11:34:41AM -0800, Joe Perches wrote: > If no patch is attached, you should get > > ERROR: Does not appear to be a unified-diff format patch Well, it needs to handle the case where a patch simply and only renames a file. Then, even if a patch follows: --- it says: $ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict - Must be run from the top-level dir. of a kernel tree If I comment out the following hunk: if (!defined $root) { print "Must be run from the top-level dir. of a kernel tree\n"; exit(2); } then it works, albeit with a bunch of warnings: Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. CHECK: Patch renames README to README.old, update MAINTAINERS? ... Looks like this would need a bit more work. Thanks. diff --git a/README b/README.old similarity index 99% rename from README rename to README.old index a24ec89ba442..b0a7aa56c3cc 100644 --- a/README +++ b/README.old @@ -1,3 +1,6 @@ +TEST + + Linux kernel release 3.x These are the release notes for Linux version 3. Read them carefully,