From patchwork Wed Nov 20 00:34:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 3204731 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 64A7CC045B for ; Wed, 20 Nov 2013 00:34:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7DA83206E3 for ; Wed, 20 Nov 2013 00:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F44420704 for ; Wed, 20 Nov 2013 00:34:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396Ab3KTAeT (ORCPT ); Tue, 19 Nov 2013 19:34:19 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:6668 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752199Ab3KTAeR (ORCPT ); Tue, 19 Nov 2013 19:34:17 -0500 Received: from [67.255.60.225] ([67.255.60.225:50038] helo=gandalf.local.home) by cdptpa-oedge02 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 65/62-29861-7830C825; Wed, 20 Nov 2013 00:34:15 +0000 Date: Tue, 19 Nov 2013 19:34:14 -0500 From: Steven Rostedt To: Stephen Boyd Cc: Andrew Morton , Geert Uytterhoeven , LKML , Michal Marek , linux-kbuild , Yang Bai Subject: Re: [PATCH] scripts: Have make TAGS not include structure members Message-ID: <20131119193414.48912cbd@gandalf.local.home> In-Reply-To: <528BFFBF.4050807@codeaurora.org> References: <20131115093645.6dc03918@gandalf.local.home> <20131119155907.11fbdecea0aa40764a3d927a@linux-foundation.org> <20131119190426.27b010e4@gandalf.local.home> <20131119160855.2527630f87d060801d9ee3bb@linux-foundation.org> <20131119191435.4dce1499@gandalf.local.home> <528BFFBF.4050807@codeaurora.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 19 Nov 2013 16:18:07 -0800 Stephen Boyd wrote: > I didn't have exuberant-ctags installed so 'make tags' was building the > emacs tag file as 'tags' and vim was using it just fine. Please note > that you may be affecting vim users with this change if they haven't > installed exuberant-ctags. I'm aware of that, as one of my boxes I tested this on also doesn't have exuberant-ctags either. I wasn't going to use this change, but instead add this change: --- scripts/tags.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-trace.git/scripts/tags.sh =================================================================== --- linux-trace.git.orig/scripts/tags.sh 2013-11-19 19:29:34.352371615 -0500 +++ linux-trace.git/scripts/tags.sh 2013-11-19 19:32:37.821152204 -0500 @@ -218,7 +218,7 @@ exuberant() emacs() { - all_target_sources | xargs $1 -a \ + all_target_sources | xargs $@ -a \ --regex='/^\(ENTRY\|_GLOBAL\)(\([^)]*\)).*/\2/' \ --regex='/^SYSCALL_DEFINE[0-9]?(\([^,)]*\).*/sys_\1/' \ --regex='/^TRACE_EVENT(\([^,)]*\).*/trace_\1/' \ @@ -263,7 +263,7 @@ xtags() if $1 --version 2>&1 | grep -iq exuberant; then exuberant $1 elif $1 --version 2>&1 | grep -iq emacs; then - emacs $1 + emacs $@ else all_target_sources | xargs $1 -a fi @@ -313,7 +313,7 @@ case "$1" in "TAGS") rm -f TAGS - xtags etags + xtags etags --no-members remove_structs=y ;; esac