From patchwork Mon Mar 31 14:35:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Marek X-Patchwork-Id: 3915071 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 78A219F2B6 for ; Mon, 31 Mar 2014 14:36:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9884D203B0 for ; Mon, 31 Mar 2014 14:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B796203AE for ; Mon, 31 Mar 2014 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753383AbaCaOfr (ORCPT ); Mon, 31 Mar 2014 10:35:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50680 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbaCaOfp (ORCPT ); Mon, 31 Mar 2014 10:35:45 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C7213AC16; Mon, 31 Mar 2014 14:35:43 +0000 (UTC) Received: by sepie.suse.cz (Postfix, from userid 10020) id 647EC40858; Mon, 31 Mar 2014 16:35:43 +0200 (CEST) Date: Mon, 31 Mar 2014 16:35:43 +0200 From: Michal Marek To: Fengguang Wu Cc: Bjorn Helgaas , "linux-mtd@lists.infradead.org" , LKML , David Woodhouse , Brian Norris , linux-kbuild Subject: Re: [mtd/sbc_gxx] kernel BUG at include/linux/mtd/map.h:148! Message-ID: <20140331143543.GA9764@sepie.suse.cz> References: <20140327140140.GA9083@localhost> <20140331113412.GA13548@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140331113412.GA13548@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Mar 31, 2014 at 07:34:12PM +0800, Fengguang Wu wrote: > CC Michal and kbuild list. > > On Thu, Mar 27, 2014 at 04:51:53PM -0600, Bjorn Helgaas wrote: > > [+cc David, Brian] > > > > On Thu, Mar 27, 2014 at 8:01 AM, Fengguang Wu wrote: > > > FYI, here is a very old warning, too old to be bisected. > > > > > > [ 5.282127] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA > > > [ 5.286079] SBC-GXx flash: IO:0x258-0x259 MEM:0xdc000-0xdffff > > > [ 5.288723] ------------[ cut here ]------------ > > > [ 5.289649] kernel BUG at include/linux/mtd/map.h:148! > > > > I think the problem is that your randconfig happens to have none of > > CONFIG_MTD_MAP_BANK_WIDTH_* set (you should have played the lottery > > today!), and the default implementation of map_bankwidth() in that > > case is just "BUG()": > > > > $ grep MTD_MAP config-3.14.0-rc8-wl-03045-gdf16ea4 > > # CONFIG_MTD_MAP_BANK_WIDTH_1 is not set > > # CONFIG_MTD_MAP_BANK_WIDTH_2 is not set > > # CONFIG_MTD_MAP_BANK_WIDTH_4 is not set > > # CONFIG_MTD_MAP_BANK_WIDTH_8 is not set > > # CONFIG_MTD_MAP_BANK_WIDTH_16 is not set > > # CONFIG_MTD_MAP_BANK_WIDTH_32 is not set > > > > I don't know enough Kconfig or MTD to fix this. > > Michal, the problem we run into is, how to select one of the above > CONFIG_MTD_MAP_BANK_WIDTH_xx in "make randconfig". You can't enforce this in Kconfig. What you can do is to make the logic more fool-proof and fall back to some sensible default if none of the CONFIG_MTD_MAP_BANK_WIDTH_* options is enabled. Like this From 76e66ceea7e2ffbb1d39c01af2eaf6f2b66c2be3 Mon Sep 17 00:00:00 2001 From: Michal Marek Date: Mon, 31 Mar 2014 16:25:32 +0200 Subject: [PATCH] mtd: Fall back to MTD_MAP_BANK_WIDTH_1 if none is specified This is mainly to fix make randconfig errors. Signed-off-by: Michal Marek Tested-by: Jet Chen --- drivers/mtd/chips/Kconfig | 8 ++++++++ include/linux/mtd/map.h | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig index e4696b3..219de49 100644 --- a/drivers/mtd/chips/Kconfig +++ b/drivers/mtd/chips/Kconfig @@ -115,6 +115,14 @@ config MTD_MAP_BANK_WIDTH_32 If you wish to support CFI devices on a physical bus which is 256 bits wide, say 'Y'. +config HAVE_MTD_MAP_BANK_WIDTH_1 + bool + default MTD_MAP_BANK_WIDTH_1 || (!MTD_MAP_BANK_WIDTH_2 && !MTD_MAP_BANK_WIDTH_4 && !MTD_MAP_BANK_WIDTH_8 && !MTD_MAP_BANK_WIDTH_16 && !MTD_MAP_BANK_WIDTH_32) + +if HAVE_MTD_MAP_BANK_WIDTH_1 && !MTD_MAP_BANK_WIDTH_1 +comment "no buswidth selected, using 8-bit as a fallback " +endif + config MTD_CFI_I1 bool "Support 1-chip flash interleave" if MTD_CFI_GEOMETRY default y diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index 5f487d7..d4f4f49 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -32,7 +32,7 @@ #include #include -#ifdef CONFIG_MTD_MAP_BANK_WIDTH_1 +#ifdef CONFIG_HAVE_MTD_MAP_BANK_WIDTH_1 #define map_bankwidth(map) 1 #define map_bankwidth_is_1(map) (map_bankwidth(map) == 1) #define map_bankwidth_is_large(map) (0) @@ -156,7 +156,7 @@ static inline int map_bankwidth(void *map) static inline int map_bankwidth_supported(int w) { switch (w) { -#ifdef CONFIG_MTD_MAP_BANK_WIDTH_1 +#ifdef CONFIG_HAVE_MTD_MAP_BANK_WIDTH_1 case 1: #endif #ifdef CONFIG_MTD_MAP_BANK_WIDTH_2