From patchwork Wed Oct 22 19:44:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Marek X-Patchwork-Id: 5136711 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6CCE89F349 for ; Wed, 22 Oct 2014 19:44:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5E0C920256 for ; Wed, 22 Oct 2014 19:44:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB1EA20222 for ; Wed, 22 Oct 2014 19:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932481AbaJVToN (ORCPT ); Wed, 22 Oct 2014 15:44:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46564 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161AbaJVToM (ORCPT ); Wed, 22 Oct 2014 15:44:12 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AD00175021; Wed, 22 Oct 2014 19:44:09 +0000 (UTC) Received: by pobox.suse.cz (Postfix, from userid 10020) id D97E5C22A1; Wed, 22 Oct 2014 21:44:08 +0200 (CEST) Date: Wed, 22 Oct 2014 21:44:08 +0200 From: Michal Marek To: Steven Rostedt Cc: LKML , Masahiro Yamada , Peter Foley , linux-kbuild@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] kbuild: Fix output of make kernelrelease Message-ID: <20141022194408.GA20989@pobox.suse.cz> References: <20141022101944.70d637cc@gandalf.local.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141022101944.70d637cc@gandalf.local.home> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dne 22.10.2014 v 16:19 Steven Rostedt napsal(a): > > Commit 7ff525712acf "kbuild: fake the "Entering directory ..." message > more simply" changed the output of "make kernelrelease" such that the > kernel release version was not the last line printed. This broke various > tools that would find the kernel release with "make kernelrelease | tail -1". The cleaner and recommended (see recent make help) way is to use make -s: $ make O=build -s kernelrelease 3.18.0-rc1+ no further processing is needed. > One of those tools that broke was ktest.pl which resides in the kernel. Can you please apply this patch? Thanks, Michal From c660b235e25eee053337e0e6c952e87f39839c63 Mon Sep 17 00:00:00 2001 From: Michal Marek Date: Wed, 22 Oct 2014 21:25:39 +0200 Subject: [PATCH] ktest: Use make -s kernelrelease The previous tail -1 broke with commit 7ff525712acf ("kbuild: fake the "Entering directory ..." message more simply") Reported-by: Steven Rostedt Signed-off-by: Michal Marek --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index bf13981..60fe020 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -2005,7 +2005,7 @@ sub get_version { # get the release name return if ($have_version); doprint "$make kernelrelease ... "; - $version = `$make kernelrelease | tail -1`; + $version = `$make -s kernelrelease`; chomp($version); doprint "$version\n"; $have_version = 1;