From patchwork Wed Oct 14 14:03:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Marek X-Patchwork-Id: 7395931 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C0AED9F36A for ; Wed, 14 Oct 2015 14:04:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D891E20899 for ; Wed, 14 Oct 2015 14:04:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5D6620893 for ; Wed, 14 Oct 2015 14:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbbJNODt (ORCPT ); Wed, 14 Oct 2015 10:03:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:56733 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753580AbbJNOD1 (ORCPT ); Wed, 14 Oct 2015 10:03:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9BEBCAD53; Wed, 14 Oct 2015 14:03:24 +0000 (UTC) Received: by sepie.suse.cz (Postfix, from userid 10020) id 92B8B40838; Wed, 14 Oct 2015 16:03:25 +0200 (CEST) Date: Wed, 14 Oct 2015 16:03:25 +0200 From: Michal Marek To: Thiago Macieira , linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Boris Barbulovski Subject: Re: [PATCH 31/39] Port xconfig to Qt5 - Add horizontal scrollbar, and scroll per pixel. Message-ID: <20151014140325.GA30722@sepie.suse.cz> References: <1442946999-37018-1-git-send-email-thiago.macieira@intel.com> <1442946999-37018-32-git-send-email-thiago.macieira@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1442946999-37018-32-git-send-email-thiago.macieira@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 2015-09-22 20:36, Thiago Macieira wrote: > From: Boris Barbulovski > > Signed-off-by: Boris Barbulovski > Signed-off-by: Thiago Macieira > --- > scripts/kconfig/qconf.cc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > index e5bfa6b..2ef06c1 100644 > --- a/scripts/kconfig/qconf.cc > +++ b/scripts/kconfig/qconf.cc > @@ -318,6 +318,9 @@ ConfigList::ConfigList(ConfigView* p, const char *name) > setSortingEnabled(false); > setRootIsDecorated(true); > > + setVerticalScrollMode(ScrollPerPixel); > + setHorizontalScrollMode(ScrollPerPixel); > + > setHeaderLabels(QStringList() << _("Option") << _("Name") << "N" << "M" << "Y" << _("Value")); > > connect(this, SIGNAL(itemSelectionChanged(void)), > @@ -453,11 +456,13 @@ void ConfigList::updateList(ConfigItem* item) > > updateMenuList(item, rootEntry); > update(); > + resizeColumnToContents(0); > return; > } > update: > updateMenuList(this, rootEntry); > update(); > + resizeColumnToContents(0); > } Somehow one of the patches to ConfigList (not this one) caused the columns to take too much space. To reproduce this, enable Show Name, Show Range and Show Data in the Option menu. Do you see the same issue? The following patch fixes it for me, but perhaps there is a cleaner way to do it. Michal --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index 73ce56a76271..1a428127711b 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -451,13 +451,17 @@ void ConfigList::updateList(ConfigItem* item) updateMenuList(item, rootEntry); update(); - resizeColumnToContents(0); + for (int i = 0; i < columnCount(); i++) { + resizeColumnToContents(i); + } return; } update: updateMenuList(this, rootEntry); update(); - resizeColumnToContents(0); + for (int i = 0; i < columnCount(); i++) { + resizeColumnToContents(i); + } } void ConfigList::setValue(ConfigItem* item, tristate val)