From patchwork Mon Feb 22 19:16:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emese Revfy X-Patchwork-Id: 8382301 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 981559F2F0 for ; Mon, 22 Feb 2016 19:18:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8DE75204AB for ; Mon, 22 Feb 2016 19:18:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FB392021B for ; Mon, 22 Feb 2016 19:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648AbcBVTR7 (ORCPT ); Mon, 22 Feb 2016 14:17:59 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:33346 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbcBVTR7 (ORCPT ); Mon, 22 Feb 2016 14:17:59 -0500 Received: by mail-wm0-f48.google.com with SMTP id g62so171004683wme.0 for ; Mon, 22 Feb 2016 11:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=RBeOkup1jWBURAnxSBXoby7wZY+0g20rD/2pfLRjR/4=; b=eo/D1f5iVawUv8JYpbgSr5pyH5hkXzA5O9t9C8JSqucxv6rpXtGF9fbZc3AJejsKQx AQUq0N/HWIF0aPG/nMWm992rK0UmzbSNQzyqJdnP3oQji+Gu4vt3JCDqzbpVSc8gr9la D913pZk5CLJXkjQjhTGYPYzoNPe4Gm4UZ92nP2YE7b5T/Ft70Mry0dnKNwbw5Dh/219z lv8yJ6ibndz1frICREtHmFJSJVDd0Tl62NJIcaQXFHHa8oETg8bZ+YbdgFrj1ODEC0cl YfkFApVNUpaylbFYfey6H7s0mkYr4zbiX5nPr1JBXHTseR7DnI4CtS/mLv2Rim9Ub62v tdmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=RBeOkup1jWBURAnxSBXoby7wZY+0g20rD/2pfLRjR/4=; b=WrAQrFctaVfiXV+BtZXZcKszr4ASlr0uT6VhJJNNpgp5w0b2NwPyoY88gzopUqw891 wOIIm25mH5EyIv6YesG/JXi1efj3vbqKbcx30lrGs6/04Cji22OQk8zprelRjkAGZ36T n35rScgKtwrJMtv9Y0FwXHF6ZH53aoQFKR2vtKbBXPFtwjpDbgaMWPMwMc0N+Gx+EnJJ 7vyBhv75EPFCkshsIIyn4fLGDKoeUz7qsvJp4thFbCbhrQyfBZfIrchi3zHUEw+ga+q8 eVMGW2jC+xBjUHmIVXBPFQlMKp527QFeRCpU+9tZ5hNzqveFXU7kG2lNqSbraU11acOi XkxA== X-Gm-Message-State: AG10YOTHKIyBPjJcM6xd3wbFLktor8RAtt0QxVHUvUzCiF94jyJojCd93quPqJsPnaXp+A== X-Received: by 10.28.214.11 with SMTP id n11mr13233861wmg.31.1456168677919; Mon, 22 Feb 2016 11:17:57 -0800 (PST) Received: from localhost (beleg.madhouse-project.org. [128.199.36.147]) by smtp.gmail.com with ESMTPSA id g3sm26010505wjw.31.2016.02.22.11.17.55 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Feb 2016 11:17:56 -0800 (PST) Date: Mon, 22 Feb 2016 20:16:06 +0100 From: Emese Revfy To: linux-kbuild@vger.kernel.org Cc: pageexec@freemail.hu, spender@grsecurity.net, kernel-hardening@lists.openwall.com, mmarek@suse.com, keescook@chromium.org, linux@rasmusvillemoes.dk Subject: [PATCH v3 2/3] Add Cyclomatic complexity GCC plugin Message-Id: <20160222201606.72cfb9224e24c7bcc9bc1588@gmail.com> In-Reply-To: <20160222201335.449323716ca4d929f92424d5@gmail.com> References: <20160222201335.449323716ca4d929f92424d5@gmail.com> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.29; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add a very simple plugin to demonstrate the GCC plugin infrastructure. This GCC plugin computes the cyclomatic complexity of each function. The complexity M of a function's control flow graph is defined as: M = E - N + 2P where E = the number of edges N = the number of nodes P = the number of connected components (exit nodes). --- arch/Kconfig | 11 ++++++ scripts/Makefile.gcc-plugins | 6 +++- tools/gcc/Makefile | 2 ++ tools/gcc/cyc_complexity_plugin.c | 70 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 88 insertions(+), 1 deletion(-) create mode 100644 tools/gcc/cyc_complexity_plugin.c diff --git a/arch/Kconfig b/arch/Kconfig index 4570600..b8b1afc 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -365,6 +365,17 @@ config HAVE_GCC_PLUGINS An arch should select this symbol if it supports building with gcc plugins. +config GCC_PLUGIN_CYC_COMPLEXITY + bool "Compute the cyclomatic complexity of a function" + depends on HAVE_GCC_PLUGINS + help + The complexity M of a function's control flow graph is defined as: + M = E - N + 2P + where + + E = the number of edges + N = the number of nodes + P = the number of connected components (exit nodes). endmenu # "GCC plugins" diff --git a/scripts/Makefile.gcc-plugins b/scripts/Makefile.gcc-plugins index fa0a631..11dc2ac 100644 --- a/scripts/Makefile.gcc-plugins +++ b/scripts/Makefile.gcc-plugins @@ -4,7 +4,11 @@ else PLUGINCC := $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-plugin.sh "$(HOSTCC)" "$(HOSTCXX)" "$(CC)") endif ifneq ($(PLUGINCC),) -export PLUGINCC GCC_PLUGINS_CFLAGS GCC_PLUGINS_AFLAGS +ifdef CONFIG_GCC_PLUGIN_CYC_COMPLEXITY +GCC_PLUGIN_CYC_COMPLEXITY_CFLAGS := -fplugin=$(objtree)/tools/gcc/cyc_complexity_plugin.so +endif +GCC_PLUGINS_CFLAGS := $(GCC_PLUGIN_CYC_COMPLEXITY_CFLAGS) +export PLUGINCC GCC_PLUGINS_CFLAGS GCC_PLUGINS_AFLAGS GCC_PLUGIN_CYC_COMPLEXITY ifeq ($(KBUILD_EXTMOD),) gcc-plugins: $(Q)$(MAKE) $(build)=tools/gcc diff --git a/tools/gcc/Makefile b/tools/gcc/Makefile index 10c8b30..31c72bf 100644 --- a/tools/gcc/Makefile +++ b/tools/gcc/Makefile @@ -12,6 +12,8 @@ endif export GCCPLUGINS_DIR HOSTLIBS +$(HOSTLIBS)-$(CONFIG_GCC_PLUGIN_CYC_COMPLEXITY) := cyc_complexity_plugin.so + always := $($(HOSTLIBS)-y) cyc_complexity_plugin-objs := cyc_complexity_plugin.o diff --git a/tools/gcc/cyc_complexity_plugin.c b/tools/gcc/cyc_complexity_plugin.c new file mode 100644 index 0000000..5593a32 --- /dev/null +++ b/tools/gcc/cyc_complexity_plugin.c @@ -0,0 +1,70 @@ +/* + * Copyright 2011-2016 by Emese Revfy + * Licensed under the GPL v2, or (at your option) v3 + * + * Homepage: + * https://github.com/ephox-gcc-plugins/cyclomatic_complexity + * + * http://en.wikipedia.org/wiki/Cyclomatic_complexity + * The complexity M is then defined as: + * M = E - N + 2P + * where + * + * E = the number of edges of the graph + * N = the number of nodes of the graph + * P = the number of connected components (exit nodes). + * + * Usage (4.5 - 5): + * $ make clean; make run + */ + +#include "gcc-common.h" + +int plugin_is_GPL_compatible; + +static struct plugin_info cyc_complexity_plugin_info = { + .version = "20160217", + .help = "Cyclomatic Complexity\n", +}; + +static unsigned int cyc_complexity_execute(void) +{ + int complexity; + expanded_location xloc; + + // M = E - N + 2P + complexity = n_edges_for_fn(cfun) - n_basic_blocks_for_fn(cfun) + 2; + + xloc = expand_location(DECL_SOURCE_LOCATION(current_function_decl)); + fprintf(stderr, "Cyclomatic Complexity %d %s:%s\n", complexity, xloc.file, DECL_NAME_POINTER(current_function_decl)); + + return 0; +} + +#define PASS_NAME cyc_complexity + +#define NO_GATE +#define TODO_FLAGS_FINISH TODO_dump_func + +#include "gcc-generate-gimple-pass.h" + +int plugin_init(struct plugin_name_args *plugin_info, struct plugin_gcc_version *version) +{ + const char * const plugin_name = plugin_info->base_name; + struct register_pass_info cyc_complexity_pass_info; + + cyc_complexity_pass_info.pass = make_cyc_complexity_pass(); + cyc_complexity_pass_info.reference_pass_name = "ssa"; + cyc_complexity_pass_info.ref_pass_instance_number = 1; + cyc_complexity_pass_info.pos_op = PASS_POS_INSERT_AFTER; + + if (!plugin_default_version_check(version, &gcc_version)) { + error(G_("incompatible gcc/plugin versions")); + return 1; + } + + register_callback(plugin_name, PLUGIN_INFO, NULL, &cyc_complexity_plugin_info); + register_callback(plugin_name, PLUGIN_PASS_MANAGER_SETUP, NULL, &cyc_complexity_pass_info); + + return 0; +}