| Message ID | 20170105102936.5673-1-npiggin@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/05/2017 02:29 AM, Nicholas Piggin wrote: > When using initramfs compression, the data file compression suffix > gets quotes pulled in from Kconfig, e.g., initramfs_data.cpio".gz" > which make does not match a target and causes rebuild. > > Fix this by filtering out quotes from the Kconfig string. > > Fixes: 35e669e1a254 ("initramfs: select builtin initram compression algorithm on KConfig instead of Makefile") > Reviewed-by: Francisco Blas Izquierdo Riera (klondike) <klondike@klondike.es> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/usr/Makefile b/usr/Makefile index 17a513268325..746c3fd0b933 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -5,7 +5,7 @@ klibcdirs:; PHONY += klibcdirs -suffix_y = $(CONFIG_INITRAMFS_COMPRESSION) +suffix_y = $(subst $\",,$(CONFIG_INITRAMFS_COMPRESSION)) AFLAGS_initramfs_data.o += -DINITRAMFS_IMAGE="usr/initramfs_data.cpio$(suffix_y)" # Generate builtin.o based on initramfs_data.o
When using initramfs compression, the data file compression suffix gets quotes pulled in from Kconfig, e.g., initramfs_data.cpio".gz" which make does not match a target and causes rebuild. Fix this by filtering out quotes from the Kconfig string. Fixes: 35e669e1a254 ("initramfs: select builtin initram compression algorithm on KConfig instead of Makefile") Reviewed-by: Francisco Blas Izquierdo Riera (klondike) <klondike@klondike.es> Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- usr/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)