From patchwork Tue Sep 26 02:28:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 9970963 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8491B602BD for ; Tue, 26 Sep 2017 02:29:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 753D028D8A for ; Tue, 26 Sep 2017 02:29:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 69AF228D8F; Tue, 26 Sep 2017 02:29:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C09D28D8A for ; Tue, 26 Sep 2017 02:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967377AbdIZC2y (ORCPT ); Mon, 25 Sep 2017 22:28:54 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37643 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966283AbdIZC2v (ORCPT ); Mon, 25 Sep 2017 22:28:51 -0400 Received: by mail-pf0-f194.google.com with SMTP id e69so4394308pfg.4; Mon, 25 Sep 2017 19:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cqzr3emdSkDvkh/3um/8W5CFRtSZI3Q1PkbmlNrWzgc=; b=GmbUBTiOCqE59XIvVlBl/RSERWeONOKXLHaOUiXOdXh3Tb+39+oEOl2l4thPqw5Cly czmMBhcPH2bOWzeuAMOAWJTd3+4eHXJnDKy9UpdeqKXDjp6aEHD9ZvBtQoh0GSV13Ig+ DsVBl4cDwQ+m3s9NuGftc/F9Jdc+ORbo5yiILi/M0CKTPlofqNrMg0hB30y8xFMkD/AB oWfDGcICQcGqGHW6691wahj0vaFaIOhuuFfZNQKl4JtJk2kN/gG5u/X43eQS3khQddak z/LzKJ1gyplkxw7J1OMePtvhtiHZEP0nk6mGZIV/YrmJIqVnV/ZXnLd9p9BtBl1Lnxer dP1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cqzr3emdSkDvkh/3um/8W5CFRtSZI3Q1PkbmlNrWzgc=; b=dbTb6/jeO+GllTfcJRavMRi8uqgxmVNEH2P0sON0L+IxdbrNGNn3xeS4zEXD3En5qO JNTovdD+7IYQp1QG+Othipq1x+HZfvL9NPHF+8QJgLjdjB54i3G85o6m+/fHBNGuS2Ua bkU+YrK3sNiFYUAx3D9SanF+mjTffM12hdk47ORLTU/NMtTZ+MJo0B/WemLOSlKyq3de Y4q9RT1LYSl2xb2EGLxJelUnRsHBg5violhMGf1vBlHVI0Qn6T3qD7OGN1sjx8LF707U +MyCvb0TVc7nhrj0ZUuLTR4o1aJILmyAnN90iOwcGApm899ktIR8Wdja/o6rjcrr4xQ2 T26Q== X-Gm-Message-State: AHPjjUhe2XFZhi6r8BLkPsI0nfyFNR95+UDPnWuDqch/Gi0Xm6rABxKF db6EuDT1Vxu+rCRakLdzhHA= X-Google-Smtp-Source: AOwi7QAgKogqpZY9tO0wBgWWJAUwKjSnU4lediwbsZWphLaHgvFlpLenAVt2YJLLIy5QE8MjtTzWGQ== X-Received: by 10.84.131.101 with SMTP id 92mr9159132pld.97.1506392930591; Mon, 25 Sep 2017 19:28:50 -0700 (PDT) Received: from localhost.localdomain ([2601:647:4701:31a:320e:d5ff:febd:81c]) by smtp.googlemail.com with ESMTPSA id r12sm12727376pgp.81.2017.09.25.19.28.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Sep 2017 19:28:49 -0700 (PDT) From: Nick Desaulniers Cc: behanw@converseincode.com, dl9pf@gmx.de, charlebm@gmail.com, mka@chromium.org, ghackmann@google.com, md@google.com, Nick Desaulniers , Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] kbuild: clang: remove crufty HOSTCFLAGS Date: Mon, 25 Sep 2017 19:28:35 -0700 Message-Id: <20170926022835.30916-1-nick.desaulniers@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When compiling with `make CC=clang HOSTCC=clang`, I was seeing warnings that clang did not recognize -fno-delete-null-pointer-checks for HOSTCC targets. These were added in commit 61163efae020 ("kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang"). That patch wraps that flag in cc-option for KBUILD_CFLAGS, but not hostcc-option for HOSTCFLAGS. Either hostcc-option did not exist, or the author was not setting HOSTCC to clang as well as CC when authored. It's not clear why the other warnings were disabled, and just for HOSTCFLAGS, but I can remove them, add -Werror to HOSTCFLAGS and compile with clang just fine. Signed-off-by: Nick Desaulniers --- * It may also be worthwhile keep the old flags, and simply wrap everything in hostcc-option. Makefile | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Makefile b/Makefile index d1119941261c..2e908969e0d8 100644 --- a/Makefile +++ b/Makefile @@ -301,16 +301,12 @@ HOST_LFS_LIBS := $(shell getconf LFS_LIBS) HOSTCC = gcc HOSTCXX = g++ HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ + $(call hostcc-option,-fno-delete-null-pointer-checks) \ -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) HOST_LOADLIBES := $(HOST_LFS_LIBS) -ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1) -HOSTCFLAGS += -Wno-unused-value -Wno-unused-parameter \ - -Wno-missing-field-initializers -fno-delete-null-pointer-checks -endif - # Decide whether to build built-in, modular, or both. # Normally, just do built-in.