Message ID | 20180221042507.31379-1-caoj.fnst@cn.fujitsu.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
2018-02-21 13:25 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>: > GCC_PLUGINS_CFLAGS is already in the environment, so it is superfluous > to add it in commanline of final build of init/ > > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> Applied to linux-kbuild, with 'commanline' fixed to 'command line'.
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index e6818b8e7141..e07b2d251ad6 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -248,7 +248,7 @@ else fi; # final build of init/ -${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init GCC_PLUGINS_CFLAGS="${GCC_PLUGINS_CFLAGS}" +${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init archive_builtin
GCC_PLUGINS_CFLAGS is already in the environment, so it is superfluous to add it in commanline of final build of init/ Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> --- This is only tested with Randomizing Structure Layout plugin. The test method is not so grace but I think it can prove the correctness of this patch. On the other hand, if we concerns that some flags cannot be passed during final build, should also consider all the other flags. Currently, with Randomizing plugin enabled, the crash utility can't work with it, the symptom is a Segmentation fault due to infinite function call. With the patch, the symptom is exactly the same, so I am sure the plugin works. scripts/link-vmlinux.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)