| Message ID | 20200109161636.9362-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] kconfig: fix an "implicit declaration of function" warning | expand |
On Fri, Jan 10, 2020 at 1:16 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > strncasecmp() & strcasecmp() functions are declared in strings.h, not > string.h. On most environments the former is implicitly included by > the latter but on some setups, building menuconfig results in the > following warning: > > HOSTCC scripts/kconfig/mconf.o > scripts/kconfig/mconf.c: In function ‘search_conf’: > scripts/kconfig/mconf.c:423:6: warning: implicit declaration of function ‘strncasecmp’ [-Wimplicit-function-declaration] > if (strncasecmp(dialog_input_result, CONFIG_, strlen(CONFIG_)) == 0) > ^~~~~~~~~~~ > scripts/kconfig/mconf.c: In function ‘main’: > scripts/kconfig/mconf.c:1021:8: warning: implicit declaration of function ‘strcasecmp’ [-Wimplicit-function-declaration] > if (!strcasecmp(mode, "single_menu")) > ^~~~~~~~~~ > > Fix it by explicitly including strings.h. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Applied to linux-kbuild. Thanks.
diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c index e36b342f1065..5527482c3077 100644 --- a/scripts/kconfig/gconf.c +++ b/scripts/kconfig/gconf.c @@ -18,6 +18,7 @@ #include <stdio.h> #include <string.h> +#include <strings.h> #include <unistd.h> #include <time.h> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c index 49c26ea9dd98..4063dbc1b927 100644 --- a/scripts/kconfig/mconf.c +++ b/scripts/kconfig/mconf.c @@ -15,6 +15,7 @@ #include <stdarg.h> #include <stdlib.h> #include <string.h> +#include <strings.h> #include <signal.h> #include <unistd.h> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c index b7c1ef757178..daf1c1506ec4 100644 --- a/scripts/kconfig/nconf.c +++ b/scripts/kconfig/nconf.c @@ -8,6 +8,7 @@ #define _GNU_SOURCE #endif #include <string.h> +#include <strings.h> #include <stdlib.h> #include "lkc.h"