| Message ID | 20200925152121.20527-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Documentation/llvm: Fix clang target examples | expand |
On Fri, Sep 25, 2020 at 8:21 AM Florian Fainelli <f.fainelli@gmail.com> wrote: > > clang --target=<triple> is how we can specify a particular toolchain > triple to be use, fix the two occurences in the documentation. Ah right, my mistake. It's either double dash+equals, or single dash+space. Thanks for the patch. Masahiro, would you mind picking this up? Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Documentation/kbuild/llvm.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst > index 334df758dce3..dae90c21aed3 100644 > --- a/Documentation/kbuild/llvm.rst > +++ b/Documentation/kbuild/llvm.rst > @@ -39,10 +39,10 @@ which can help simplify cross compiling. :: > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang > > ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead > -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For > +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For > example: :: > > - clang --target aarch64-linux-gnu foo.c > + clang --target=aarch64-linux-gnu foo.c > > LLVM Utilities > -------------- > -- > 2.25.1 >
On Fri, Sep 25, 2020 at 08:21:14AM -0700, Florian Fainelli wrote: > clang --target=<triple> is how we can specify a particular toolchain > triple to be use, fix the two occurences in the documentation. > > Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Thank you for the patch! > --- > Documentation/kbuild/llvm.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst > index 334df758dce3..dae90c21aed3 100644 > --- a/Documentation/kbuild/llvm.rst > +++ b/Documentation/kbuild/llvm.rst > @@ -39,10 +39,10 @@ which can help simplify cross compiling. :: > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang > > ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead > -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For > +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For > example: :: > > - clang --target aarch64-linux-gnu foo.c > + clang --target=aarch64-linux-gnu foo.c > > LLVM Utilities > -------------- > -- > 2.25.1 >
On Sat, Sep 26, 2020 at 3:52 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Fri, Sep 25, 2020 at 8:21 AM Florian Fainelli <f.fainelli@gmail.com> wrote: > > > > clang --target=<triple> is how we can specify a particular toolchain > > triple to be use, fix the two occurences in the documentation. > > Ah right, my mistake. It's either double dash+equals, or single > dash+space. Thanks for the patch. Masahiro, would you mind picking > this up? Sure. Applied to linux-kbuild/fixes. Thanks. > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > > > > Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM") > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > > --- > > Documentation/kbuild/llvm.rst | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst > > index 334df758dce3..dae90c21aed3 100644 > > --- a/Documentation/kbuild/llvm.rst > > +++ b/Documentation/kbuild/llvm.rst > > @@ -39,10 +39,10 @@ which can help simplify cross compiling. :: > > ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang > > > > ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead > > -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For > > +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For > > example: :: > > > > - clang --target aarch64-linux-gnu foo.c > > + clang --target=aarch64-linux-gnu foo.c > > > > LLVM Utilities > > -------------- > > -- > > 2.25.1 > > > > > -- > Thanks, > ~Nick Desaulniers
diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst index 334df758dce3..dae90c21aed3 100644 --- a/Documentation/kbuild/llvm.rst +++ b/Documentation/kbuild/llvm.rst @@ -39,10 +39,10 @@ which can help simplify cross compiling. :: ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For example: :: - clang --target aarch64-linux-gnu foo.c + clang --target=aarch64-linux-gnu foo.c LLVM Utilities --------------
clang --target=<triple> is how we can specify a particular toolchain triple to be use, fix the two occurences in the documentation. Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Documentation/kbuild/llvm.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)