| Message ID | 20221217055148.28914-1-unixbhaskar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V3] scripts: kconfig: Added static text for search information in help menu | expand |
On 12/16/22 21:51, Bhaskar Chowdhury wrote: > Reconstructed the sentence for the better readability. > > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> > --- > Changes from V2: Inducted Randy's suggestion to make it more readable. > scripts/kconfig/mconf.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c > index 9d3cf510562f..760ebf6c20b1 100644 > --- a/scripts/kconfig/mconf.c > +++ b/scripts/kconfig/mconf.c > @@ -161,6 +161,12 @@ static const char mconf_readme[] = > "(especially with a larger number of unrolled categories) than the\n" > "default mode.\n" > "\n" > + > +"Search\n" > +"-------\n" > +"Pressing the forward-slash (/) anywhere brings up a search dialog box.\n" > +"\n" > + > "Different color themes available\n" > "--------------------------------\n" > "It is possible to select different color themes using the variable\n" > -- > 2.38.1 >
On Sat 17 Dec 2022 11:21:48 GMT, Bhaskar Chowdhury wrote: > Reconstructed the sentence for the better readability. > > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> I liked the commit message your v1 much better (minimally changed): > Add few static text to explain how one can bring up the search dialog box by > pressing the forward slash key anywhere on this interface. Would you mind updating it once again? Kind regards, Nicolas
On Fri, Dec 23, 2022 at 8:51 PM Nicolas Schier <nicolas@fjasle.eu> wrote: > > On Sat 17 Dec 2022 11:21:48 GMT, Bhaskar Chowdhury wrote: > > Reconstructed the sentence for the better readability. > > > > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> > > I liked the commit message your v1 much better (minimally changed): > > Add few static text to explain how one can bring up the search dialog box by > > pressing the forward slash key anywhere on this interface. > > Would you mind updating it once again? > > Kind regards, > Nicolas I replaced the commit description with v1's one, and applied. Thanks.
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c index 9d3cf510562f..760ebf6c20b1 100644 --- a/scripts/kconfig/mconf.c +++ b/scripts/kconfig/mconf.c @@ -161,6 +161,12 @@ static const char mconf_readme[] = "(especially with a larger number of unrolled categories) than the\n" "default mode.\n" "\n" + +"Search\n" +"-------\n" +"Pressing the forward-slash (/) anywhere brings up a search dialog box.\n" +"\n" + "Different color themes available\n" "--------------------------------\n" "It is possible to select different color themes using the variable\n"
Reconstructed the sentence for the better readability. Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> --- Changes from V2: Inducted Randy's suggestion to make it more readable. scripts/kconfig/mconf.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.38.1