| Message ID | 20221228-drop-qunused-arguments-v1-9-658cbc8fc592@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS | expand |
Nathan Chancellor <nathan@kernel.org> writes: > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > warns that KBUILD_AFLAGS_64 contains '-s', which is a linking phase > option, so it is unused. > > clang-16: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument] > > There appears to be no equivalent for '-s' in GNU as; 'as --help' on > x86_64 notes that '-s' is ignored and 's390x-linux-gnu-as --help' makes > no mention of it whatsoever. > > Just drop '-s' altogether, as it has been there since the introduction > of the vDSO, which means it is likely uneeded, given there would likely > have been a report by this point. > > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Sven Schnelle <svens@linux.ibm.com>
diff --git a/arch/s390/kernel/vdso64/Makefile b/arch/s390/kernel/vdso64/Makefile index 9e2b95a222a9..a2fe9383d452 100644 --- a/arch/s390/kernel/vdso64/Makefile +++ b/arch/s390/kernel/vdso64/Makefile @@ -22,7 +22,7 @@ KBUILD_AFLAGS += -DBUILD_VDSO KBUILD_CFLAGS += -DBUILD_VDSO -DDISABLE_BRANCH_PROFILING KBUILD_AFLAGS_64 := $(filter-out -m64,$(KBUILD_AFLAGS)) -KBUILD_AFLAGS_64 += -m64 -s +KBUILD_AFLAGS_64 += -m64 KBUILD_CFLAGS_64 := $(filter-out -m64,$(KBUILD_CFLAGS)) KBUILD_CFLAGS_64 += -m64 -fPIC -shared -fno-common -fno-builtin
When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it warns that KBUILD_AFLAGS_64 contains '-s', which is a linking phase option, so it is unused. clang-16: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument] There appears to be no equivalent for '-s' in GNU as; 'as --help' on x86_64 notes that '-s' is ignored and 's390x-linux-gnu-as --help' makes no mention of it whatsoever. Just drop '-s' altogether, as it has been there since the introduction of the vDSO, which means it is likely uneeded, given there would likely have been a report by this point. Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- Cc: hca@linux.ibm.com Cc: gor@linux.ibm.com Cc: agordeev@linux.ibm.com Cc: borntraeger@linux.ibm.com Cc: svens@linux.ibm.com Cc: linux-s390@vger.kernel.org --- arch/s390/kernel/vdso64/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)