| Message ID | 20230109134040.3191458-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kbuild: replace $(dot-target).tmp in filechk with $(tmp-target) | expand |
On Mon, Jan 09, 2023 at 10:40:40PM +0900 Masahiro Yamada wrote: > $(tmp-target) is a better fit for local use like this. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > scripts/Kbuild.include | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include > index 4648ab8f11d4..7778cc97a4e0 100644 > --- a/scripts/Kbuild.include > +++ b/scripts/Kbuild.include > @@ -99,11 +99,11 @@ define filechk > $(check-FORCE) > $(Q)set -e; \ > mkdir -p $(dir $@); \ > - trap "rm -f $(dot-target).tmp" EXIT; \ > - { $(filechk_$(1)); } > $(dot-target).tmp; \ > - if [ ! -r $@ ] || ! cmp -s $@ $(dot-target).tmp; then \ > + trap "rm -f $(tmp-target)" EXIT; \ > + { $(filechk_$(1)); } > $(tmp-target); \ > + if [ ! -r $@ ] || ! cmp -s $@ $(tmp-target); then \ > $(kecho) ' UPD $@'; \ > - mv -f $(dot-target).tmp $@; \ > + mv -f $(tmp-target) $@; \ > fi > endef > > -- > 2.34.1 I do fully agree. Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index 4648ab8f11d4..7778cc97a4e0 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -99,11 +99,11 @@ define filechk $(check-FORCE) $(Q)set -e; \ mkdir -p $(dir $@); \ - trap "rm -f $(dot-target).tmp" EXIT; \ - { $(filechk_$(1)); } > $(dot-target).tmp; \ - if [ ! -r $@ ] || ! cmp -s $@ $(dot-target).tmp; then \ + trap "rm -f $(tmp-target)" EXIT; \ + { $(filechk_$(1)); } > $(tmp-target); \ + if [ ! -r $@ ] || ! cmp -s $@ $(tmp-target); then \ $(kecho) ' UPD $@'; \ - mv -f $(dot-target).tmp $@; \ + mv -f $(tmp-target) $@; \ fi endef
$(tmp-target) is a better fit for local use like this. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- scripts/Kbuild.include | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)