diff mbox series

[27/27] kconfig: do not imply the type of choice value

Message ID	20240202155825.314567-28-masahiroy@kernel.org (mailing list archive)
State	New, archived
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E73D915350E; Fri, 2 Feb 2024 15:59:00 +0000 (UTC) From: Masahiro Yamada <masahiroy@kernel.org> To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org> Subject: [PATCH 27/27] kconfig: do not imply the type of choice value Date: Sat, 3 Feb 2024 00:58:25 +0900 Message-Id: <20240202155825.314567-28-masahiroy@kernel.org> In-Reply-To: <20240202155825.314567-1-masahiroy@kernel.org> References: <20240202155825.314567-1-masahiroy@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	kconfig: refactor lexer and parser code \| expand [00/27] kconfig: refactor lexer and parser code [01/27] kconfig: fix infinite loop when expanding a macro at the end of file [02/27] kconfig: fix off-by-one in zconf_error() [03/27] kconfig: remove orphan lookup_file() declaration [04/27] kconfig: remove compat_getline() [05/27] kconfig: remove unneeded sym_find() call in conf_parse() [06/27] kconfig: write Kconfig files to autoconf.cmd in order [07/27] kconfig: call env_write_dep() right after yyparse() [08/27] kconfig: split preprocessor prototypes into preprocess.h [09/27] kconfig: replace current_pos with separate cur_{filename,lineno} [10/27] kconfig: remove zconf_curname() and zconf_lineno() [11/27] kconfig: associate struct menu with file name directly [12/27] kconfig: associate struct property with file name directly [13/27] kconfig: replace file->name with name in zconf_nextfile() [14/27] kconfig: do not delay the cur_filename update [15/27] kconfig: replace remaining current_file->name with cur_filename [16/27] kconfig: move the file and lineno in struct file to struct buffer [17/27] kconfig: make file::name a flexible array member [18/27] kconfig: change file_lookup() to return the file name [19/27] kconfig: split list_head into a separate header [20/27] kconfig: resync list.h [21/27] kconfig: import more list macros and inline functions [22/27] kconfig: add macros useful for hashtable [23/27] kconfig: move ARRAY_SIZE to a header [24/27] kconfig: move strhash() to a header [25/27] kconfig: convert linked list of files to hash table [26/27] kconfig: use generic macros to implement symbol hashtable [27/27] kconfig: do not imply the type of choice value

Commit Message

Masahiro Yamada Feb. 2, 2024, 3:58 p.m. UTC

Do not feed back the choice type to choice values.

Each choice value should explicitly specify 'bool' or 'tristate',
as all the Kconfig files already do. If the type were missing,
"config symbol defined without type" would be shown.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/kconfig/menu.c | 6 ------
 1 file changed, 6 deletions(-)

diff mbox series

Patch

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 696803d944e0..44465945d6b1 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -305,12 +305,6 @@  void menu_finalize(struct menu *parent)
 					}
 				}
 			}
-			/* set the type of the remaining choice values */
-			for (menu = parent->list; menu; menu = menu->next) {
-				current_entry = menu;
-				if (menu->sym && menu->sym->type == S_UNKNOWN)
-					menu_set_type(sym->type);
-			}
 
 			/*
 			 * Use the choice itself as the parent dependency of