| Message ID | 20240213022552.754830-1-andrewjballance@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] gen_compile_commands: fix invalid escape sequence warning | expand |
On Mon 12 Feb 2024 20:25:52 GMT, Andrew Ballance wrote: > with python 12.1 '\#' results in this warning funny typo: it's Python 3.12 :) Kind regards, Nicolas > SyntaxWarning: invalid escape sequence '\#' > > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> > --- > scripts/clang-tools/gen_compile_commands.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index 5dea4479240b..93f64095fda9 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the > # kernel version). The compile_commands.json file is not interepreted > # by Make, so this code replaces the escaped version with '#'. > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') > + prefix = command_prefix.replace('\\#', '#').replace('$(pound)', '#') > > # Return the canonical path, eliminating any symbolic links encountered in the path. > abs_path = os.path.realpath(os.path.join(root_directory, file_path)) > -- > 2.43.0 >
On Tue, Feb 13, 2024 at 12:00 PM Nicolas Schier <nicolas@fjasle.eu> wrote: > > On Mon 12 Feb 2024 20:25:52 GMT, Andrew Ballance wrote: > > with python 12.1 '\#' results in this warning > > funny typo: it's Python 3.12 :) They probably meant Python 3.12.1 and forgot the "3." (or had a vim moment resulting in its unfortunate removal) > > Kind regards, > Nicolas > > > > SyntaxWarning: invalid escape sequence '\#' > > > > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> > > --- > > scripts/clang-tools/gen_compile_commands.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > > index 5dea4479240b..93f64095fda9 100755 > > --- a/scripts/clang-tools/gen_compile_commands.py > > +++ b/scripts/clang-tools/gen_compile_commands.py > > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): > > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the > > # kernel version). The compile_commands.json file is not interepreted > > # by Make, so this code replaces the escaped version with '#'. > > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') > > + prefix = command_prefix.replace('\\#', '#').replace('$(pound)', '#') > > > > # Return the canonical path, eliminating any symbolic links encountered in the path. > > abs_path = os.path.realpath(os.path.join(root_directory, file_path)) > > -- > > 2.43.0 > > > > -- > Nicolas Schier > > epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc > ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f > -- frykten for herren er opphav til kunnskap --
Hi, On Mon, Feb 12, 2024 at 6:28 PM Andrew Ballance <andrewjballance@gmail.com> wrote: > > with python 12.1 '\#' results in this warning > SyntaxWarning: invalid escape sequence '\#' Yes, since Python 3.12 escaping invalid characters will result in a SyntaxWarning. The complete table of supported escape codes is available here [1]. > > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> > --- > scripts/clang-tools/gen_compile_commands.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index 5dea4479240b..93f64095fda9 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the > # kernel version). The compile_commands.json file is not interepreted > # by Make, so this code replaces the escaped version with '#'. > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') > + prefix = command_prefix.replace('\\#', '#').replace('$(pound)', '#') I'd personally prefer using a raw string: - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') + prefix = command_prefix.replace(r'\#', '#').replace('$(pound)', '#') This makes it clear that a literal backslash followed by a literal pound sign will be replaced. > > # Return the canonical path, eliminating any symbolic links encountered in the path. > abs_path = os.path.realpath(os.path.join(root_directory, file_path)) > -- > 2.43.0 > [1]: https://docs.python.org/3/reference/lexical_analysis.html#index-23 Thanks Justin
diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py index 5dea4479240b..93f64095fda9 100755 --- a/scripts/clang-tools/gen_compile_commands.py +++ b/scripts/clang-tools/gen_compile_commands.py @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path): # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the # kernel version). The compile_commands.json file is not interepreted # by Make, so this code replaces the escaped version with '#'. - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#') + prefix = command_prefix.replace('\\#', '#').replace('$(pound)', '#') # Return the canonical path, eliminating any symbolic links encountered in the path. abs_path = os.path.realpath(os.path.join(root_directory, file_path))
with python 12.1 '\#' results in this warning SyntaxWarning: invalid escape sequence '\#' Signed-off-by: Andrew Ballance <andrewjballance@gmail.com> --- scripts/clang-tools/gen_compile_commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)