| Message ID | 20240215140702.1910276-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hexagon: select FRAME_POINTER instead of redefining it | expand |
On 2/15/24 06:07, Masahiro Yamada wrote: > Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig > should select it. > > Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS must > also be selected to avoid the unmet dependency warning. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > > arch/hexagon/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig > index a880ee067d2e..e922026fef09 100644 > --- a/arch/hexagon/Kconfig > +++ b/arch/hexagon/Kconfig > @@ -7,7 +7,9 @@ config HEXAGON > select ARCH_32BIT_OFF_T > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > select ARCH_NO_PREEMPT > + select ARCH_WANT_FRAME_POINTERS > select DMA_GLOBAL_POOL > + select FRAME_POINTER > # Other pending projects/to-do items. > # select HAVE_REGS_AND_STACK_ACCESS_API > # select HAVE_HW_BREAKPOINT if PERF_EVENTS > @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET > help > Platforms that don't load the kernel at zero set this. > > -config FRAME_POINTER > - def_bool y > - > config LOCKDEP_SUPPORT > def_bool y >
> -----Original Message----- > From: Masahiro Yamada <masahiroy@kernel.org> > Sent: Thursday, February 15, 2024 8:07 AM > To: linux-kbuild@vger.kernel.org > Cc: Masahiro Yamada <masahiroy@kernel.org>; Brian Cain > <bcain@quicinc.com>; linux-hexagon@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] hexagon: select FRAME_POINTER instead of redefining it > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig > should select it. > > Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS > must > also be selected to avoid the unmet dependency warning. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/hexagon/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig > index a880ee067d2e..e922026fef09 100644 > --- a/arch/hexagon/Kconfig > +++ b/arch/hexagon/Kconfig > @@ -7,7 +7,9 @@ config HEXAGON > select ARCH_32BIT_OFF_T > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > select ARCH_NO_PREEMPT > + select ARCH_WANT_FRAME_POINTERS > select DMA_GLOBAL_POOL > + select FRAME_POINTER > # Other pending projects/to-do items. > # select HAVE_REGS_AND_STACK_ACCESS_API > # select HAVE_HW_BREAKPOINT if PERF_EVENTS > @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET > help > Platforms that don't load the kernel at zero set this. > > -config FRAME_POINTER > - def_bool y > - > config LOCKDEP_SUPPORT > def_bool y > > -- > 2.40.1 Acked-by: Brian Cain <bcain@quicinc.com>
diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig index a880ee067d2e..e922026fef09 100644 --- a/arch/hexagon/Kconfig +++ b/arch/hexagon/Kconfig @@ -7,7 +7,9 @@ config HEXAGON select ARCH_32BIT_OFF_T select ARCH_HAS_SYNC_DMA_FOR_DEVICE select ARCH_NO_PREEMPT + select ARCH_WANT_FRAME_POINTERS select DMA_GLOBAL_POOL + select FRAME_POINTER # Other pending projects/to-do items. # select HAVE_REGS_AND_STACK_ACCESS_API # select HAVE_HW_BREAKPOINT if PERF_EVENTS @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET help Platforms that don't load the kernel at zero set this. -config FRAME_POINTER - def_bool y - config LOCKDEP_SUPPORT def_bool y
Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig should select it. Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS must also be selected to avoid the unmet dependency warning. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/hexagon/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)