| Message ID | 20240427104231.2728905-2-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kconfig: stop implification of choice type | expand |
On Sat, Apr 27, 2024 at 07:42:30PM +0900, Masahiro Yamada wrote: > If the type of choice is not specified, it is implied by the first > entry within the choice block. > > In this case, the first (and only) entry, RAPIDIO_ENUM_BASIC, is > tristate, hence this choice behaves as tristate. > > Kconfig will stop this implication because it has a bug, and 99% of > choice use cases are bool. In fact, this is the only instance of > tristate choice in the kernel. > > Before transitioning the default choice type to 'bool', specify the > type explicitly for this case. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- Reviewed-by: Nicolas Schier <n.schier@avm.de>
diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index b9f8514909bf..72b5b02492a1 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -60,7 +60,7 @@ config RAPIDIO_DEBUG If you are unsure about this, say N here. choice - prompt "Enumeration method" + tristate "Enumeration method" depends on RAPIDIO default RAPIDIO_ENUM_BASIC help
If the type of choice is not specified, it is implied by the first entry within the choice block. In this case, the first (and only) entry, RAPIDIO_ENUM_BASIC, is tristate, hence this choice behaves as tristate. Kconfig will stop this implication because it has a bug, and 99% of choice use cases are bool. In fact, this is the only instance of tristate choice in the kernel. Before transitioning the default choice type to 'bool', specify the type explicitly for this case. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)