| Message ID | 20240913171205.22126-7-david.hunter.linux@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] linux-kbuild: fix: config option can be bool | expand |
Seems fine if you fix the subject prefix and reword it in imperative mood. On Sat, Sep 14, 2024 at 2:12 AM David Hunter <david.hunter.linux@gmail.com> wrote: > > Ignore process select warnings for config entries that have a default > option. Some config entries have no prompt and nothing selects them, but > these config options are okay because they have a default option. > > Signed-off-by: David Hunter <david.hunter.linux@gmail.com> > --- > scripts/kconfig/streamline_config.pl | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl > index 593df824ead7..948437aac535 100755 > --- a/scripts/kconfig/streamline_config.pl > +++ b/scripts/kconfig/streamline_config.pl > @@ -144,6 +144,7 @@ my %selects; > my %prompts; > my %objects; > my %config2kfile; > +my %defaults; > my $var; > my $iflevel = 0; > my @ifdeps; > @@ -239,6 +240,7 @@ sub read_kconfig { > $depends{$config} .= " " . $1; > } elsif (($state eq "DEP" || $state eq "NEW") && /^\s*def(_(bool|tristate)|ault)\s+(\S.*)$/) { > my $dep = $3; > + $defaults{$config} = 1 ; > if ($dep !~ /^\s*(y|m|n)\s*$/) { > $dep =~ s/.*\sif\s+//; > $depends{$config} .= " " . $dep; > @@ -561,8 +563,16 @@ sub parse_config_selects > > # If no possible config selected this, then something happened. > if (!defined($next_config)) { > - print STDERR "WARNING: $config is required, but nothing in the\n"; > - print STDERR " current config selects it.\n"; > + > + # Some config options have no prompt, and nothing selects them, but > + # they stay turned on once the final checks for the configs > + # are done. These configs have a default option, so turn off the > + # warnings for configs with default options. > + if(!defined($defaults{$config})) { > + print STDERR "WARNING: $config is required, but nothing in the\n"; > + print STDERR " current config selects it.\n"; > + } > + > return; > } > > -- > 2.43.0 >
version 2: https://lore.kernel.org/all/20241014141345.5680-4-david.hunter.linux@gmail.com/
diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl index 593df824ead7..948437aac535 100755 --- a/scripts/kconfig/streamline_config.pl +++ b/scripts/kconfig/streamline_config.pl @@ -144,6 +144,7 @@ my %selects; my %prompts; my %objects; my %config2kfile; +my %defaults; my $var; my $iflevel = 0; my @ifdeps; @@ -239,6 +240,7 @@ sub read_kconfig { $depends{$config} .= " " . $1; } elsif (($state eq "DEP" || $state eq "NEW") && /^\s*def(_(bool|tristate)|ault)\s+(\S.*)$/) { my $dep = $3; + $defaults{$config} = 1 ; if ($dep !~ /^\s*(y|m|n)\s*$/) { $dep =~ s/.*\sif\s+//; $depends{$config} .= " " . $dep; @@ -561,8 +563,16 @@ sub parse_config_selects # If no possible config selected this, then something happened. if (!defined($next_config)) { - print STDERR "WARNING: $config is required, but nothing in the\n"; - print STDERR " current config selects it.\n"; + + # Some config options have no prompt, and nothing selects them, but + # they stay turned on once the final checks for the configs + # are done. These configs have a default option, so turn off the + # warnings for configs with default options. + if(!defined($defaults{$config})) { + print STDERR "WARNING: $config is required, but nothing in the\n"; + print STDERR " current config selects it.\n"; + } + return; }
Ignore process select warnings for config entries that have a default option. Some config entries have no prompt and nothing selects them, but these config options are okay because they have a default option. Signed-off-by: David Hunter <david.hunter.linux@gmail.com> --- scripts/kconfig/streamline_config.pl | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)