diff mbox series

[PATCH-next] modpost: Remove logically dead condition

Message ID 20241127162904.28182-1-advaitdhamorikar@gmail.com (mailing list archive)
State New
Headers show
Series [PATCH-next] modpost: Remove logically dead condition | expand

Commit Message

Advait Dhamorikar Nov. 27, 2024, 4:29 p.m. UTC
In case of failure vsnprintf returns `pos`, an unsigned long integer.
An unsigned value can never be negative, so this test will always evaluate 
the same way. 

Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
---
 scripts/mod/file2alias.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index 81f20ef13a0d..8ce48d7dd36d 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -57,11 +57,6 @@  module_alias_printf(struct module *mod, bool append_wildcard,
 	n = vsnprintf(NULL, 0, fmt, ap);
 	va_end(ap);
 
-	if (n < 0) {
-		error("vsnprintf failed\n");
-		return;
-	}
-
 	len = n + 1;	/* extra byte for '\0' */
 
 	if (append_wildcard)