From patchwork Mon Dec 4 16:55:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrey Ryabinin X-Patchwork-Id: 10091025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 272A06056E for ; Mon, 4 Dec 2017 16:51:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18EDC283FD for ; Mon, 4 Dec 2017 16:51:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DA8728D0D; Mon, 4 Dec 2017 16:51:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4E4A1283FD for ; Mon, 4 Dec 2017 16:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753006AbdLDQvu (ORCPT ); Mon, 4 Dec 2017 11:51:50 -0500 Received: from mail-he1eur01on0118.outbound.protection.outlook.com ([104.47.0.118]:15072 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752908AbdLDQvp (ORCPT ); Mon, 4 Dec 2017 11:51:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KE3VbAl1YMyDv5wRuttpjlNCpfp2fW8WS/oERBy3tXU=; b=GM93DCHtGkY2BxjSRkg5vVK/cQdLBUcCstJGJox0F/Yeefl6uLkzTW+E6dTvGZbdlCpsmreafjANZhBLSCjfa5F33DoHst+U7l5O7bal6wcLOmbA/1dolyr346pFO9JO5FVx9iW357bjBBpQmGFwPjMXkULWGwcRD1QDyLl1W8I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Received: from [172.16.25.12] (195.214.232.6) by HE1PR08MB2825.eurprd08.prod.outlook.com (2603:10a6:7:2e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Mon, 4 Dec 2017 16:51:42 +0000 Subject: Re: [PATCH v3 2/5] kasan/Makefile: Support LLVM style asan parameters. To: Paul Lawrence Cc: Alexander Potapenko , Dmitry Vyukov , Masahiro Yamada , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, Matthias Kaehlcke , Michael Davidson , Greg Hackmann References: <20171201213643.2506-1-paullawrence@google.com> <20171201213643.2506-3-paullawrence@google.com> <33f13b1a-494c-67d5-a470-294867c06f9a@virtuozzo.com> From: Andrey Ryabinin Message-ID: <2da6480e-08ff-2444-7abf-2964de53e7ff@virtuozzo.com> Date: Mon, 4 Dec 2017 19:55:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0701CA0069.eurprd07.prod.outlook.com (2603:10a6:3:64::13) To HE1PR08MB2825.eurprd08.prod.outlook.com (2603:10a6:7:2e::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4dcb2c82-0680-4e75-8767-08d53b374bff X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(2017052603286); SRVR:HE1PR08MB2825; X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB2825; 3:+3ggn2Q2Ab4MXIY6SeCrTHzzZhQOKTO/Nf2m788rUm5/Afd2JGyAHB1RwLOlVunRDWrW7CrbXB7WOr3/EYE0eZT7UV1oU62KtS1hJ1yBP1FRer/xS1I7yImhnH70iiJYE6vHRCQIb+q9cZyD9olcikyk9rWvFn25gHyLQVT7nlOME41o2/UoXTORFd/4mjYZrUydsvUl1ulgF4EgpLSrnwjO95/Y+jtkkJpKlzENuwiAhUR7DuazV6Ql7uZSc7TI; 25:WTHjYT58jT9ih4o9NwYTTRFMVLAnXkf0AIW0tZBaJJpb9/uFZaP1q8GcC8vvb0xdtpk8rLaiX2vavt7+UdiT51MI31LHbpyPLnUu7zsiqrL+MV1U5d4AquMMULBI+Pj6jqf1LkVQJnGVgmX4XpEktvZBnz2wWObuyZCChX+6+b41soXXGxkpmmY4qJB9R/Xpu2q4SfkHnyV3kddgZ0++2IOAVWGAg1+qiVLaPmtwg4Mny8gZ7onCyAa81exIn6/63qwSdW2itSmPAc5lfDYCdBDpzd9B1NW/YM1VVsoNuEPY1B3OQnlvy0DVvH9FiCEWLzqDLwJOE5x4IRWm7eBNIQ==; 31:qNtQh9C06senhZ+2+ED7oblMUYWWZFDh/yDSxKRIMwJbm9lhzb3kExRpACf6j6q8pfwzbwagooZar4KTWjmqUR6mWSna3bgbDZ+PuVzJ9tRxaUTRy9McOGwLz0DbpebTFlNQf6B5jXb4Pn0RPzU1tXPxZQMzyO5WiTKEESvuMQxu48yykOaYpbNLqgxty+hWoP2RSkFXxm4P+EUCcgDY3FSwMHq7OmrzpOJv9+D7cQg= X-MS-TrafficTypeDiagnostic: HE1PR08MB2825: X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB2825; 20:SaL97GCkByUnzcSUIaywuGbbNi4faRhlPVSu8fuTjDI/1Z952zEfMxVdeTZTQ+AH1PWVPdR5XVsKuzW6pobB326p9dRvDRmM5VkLRpGaqVH0+PZ2z5GyhRiILM4Z0LYuBgedvJjFsD5cjY1g1aFxki5D6YhVpMH/zTUogMOQCwN2S9y5MIJiC5gU6/HL8IWOxqiLWOE0deWY+uZqTrHZUEjWeyHCqoDenx8UW1clkiBlpniVlMB64jHifLBtEFApQSCpJVRw4DvsvpbPdkeazx2mkACmsqzgnW+CsqFWMLnGU0SfK6yJ3VNGOcVjmWyOMaabfzQTj+K5+gYMxeX6Osu1lfQiUXzv71Ph6vvByvL+WtD3NmCh+8g2Iv0sTZMB3Bo94d7Ih5AXsoeWVydVXjrKw8i8TqIoFdKJAZk37gc=; 4:XgpKwXW41pNM7pLymnYVnSmlILOt+UO1zVlb2HLps0pHFzGPx989XmLVyo2Aw8i2Eb5kQJXjVMzDVxgLbw1dlAr0vFEXdMWz+7XB2W15xKIHINW7owbUL0l6uxSeCz0y6ApWUqbQWFx6E8Il5IO52tXknu5GyHyel6wkaQ2OCpHNeP/yAyzpfd8DiIqPBy+S4gnYnAV2MsJF9DpIxBpu5LBOxYsvFeYaZ7cz2jg3QZS837+2rqk/6wSIfumNHGgQHI/Nj5jC4F0sAPqCQxjj7w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3231022)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011); SRVR:HE1PR08MB2825; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR08MB2825; X-Forefront-PRVS: 051158ECBB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6049001)(6009001)(376002)(346002)(366004)(24454002)(189002)(199003)(52146003)(23676004)(106356001)(2486003)(54906003)(2950100002)(53936002)(6246003)(6486002)(189998001)(33646002)(93886005)(55236003)(77096006)(52116002)(4326008)(478600001)(50466002)(31696002)(105586002)(86362001)(6116002)(58126008)(54356011)(83506002)(305945005)(6916009)(76176011)(7736002)(6666003)(68736007)(53546010)(36756003)(2870700001)(101416001)(2906002)(81166006)(8676002)(65826007)(81156014)(3846002)(97736004)(25786009)(229853002)(64126003)(7416002)(31686004)(47776003)(65956001)(16576012)(66066001)(5660300001)(16526018)(8936002)(316002)(65806001); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR08MB2825; H:[172.16.25.12]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4TUIyODI1OzIzOjNManNhWTJyenVqaWVyeW9ka2V1SXpSUDdr?= =?utf-8?B?OUlmb2JxbUVMMFcvR2hOcmhRZDJaM1Rmbm8zbFZ1MDFuaXhnK2tZQk9LS0w1?= =?utf-8?B?WG9ZQ2M5cEd3ZEk3andjclBKZFlCdFNqODJuRkI3eks0RkE0TkZqQ2RlVExB?= =?utf-8?B?UWpTdHRPSzR3eWg0UHJMenpMR3B5SXdVelFSUEI0MFYvMUFyOEJuQ2ZjeXVS?= =?utf-8?B?YnlzV01kMS9sSlQxM3Rwc3llS0xSMVladi9LU0lRVU1Fcjd4Yy9JcXRZbkdW?= =?utf-8?B?aVBMNmNVa3Q0eWtNUmVXUUJHRVFqcTZDSjZlTkpGZS9nZ2pCWkpZa2oxai9S?= =?utf-8?B?SCsvbFIxSVlsVWxVMnBWOWcveElPZFJRVlFYdlVxVmFaQUp6d1B6Z2h1cmp0?= =?utf-8?B?SXBTR3lWVUJUOWM4d1JyMDNwcU9pT3NLcEpBZWdHWDdmeWIwaHJGTE1Sak95?= =?utf-8?B?MWhLNVlvaHJVTSs5c0ZPdUcxQ3kyeHowNzArK1JTdUxiYjNHTmpKYjBkRzVv?= =?utf-8?B?K2lSMTc5ZXBTZm43UjIxaXliOEFxSkppb3RtY0lJKzVuK3BZOEJqTG91WmJp?= =?utf-8?B?QnZjdjMrMEVBdU84TUxObDNrc1JSM1BxZ1YxeDZ6aFdMeHJVVDR0MXBnVEVw?= =?utf-8?B?aHVyaVpSeStuSS9iYnA4UVpLcXdPNzZKVFFWQlNVMEN5cUtXWFptOWcxbFQz?= =?utf-8?B?OGt5UDZUd3RCYm45TzRFMnF1b0hmclRkbmtOR1dwTDVRUWxHbU1LTWVXaFFU?= =?utf-8?B?Z0dyc2Yvc3JtVzFHYW5saVJQenMxZ3ZhYklPdDlqQXlnazFySllocWwybzJy?= =?utf-8?B?UkoxbTdNM2F5cU9BYktVT3lmM1ROOERTRUZjaE52SVdzUTB1dEJvak5uYll6?= =?utf-8?B?TEpNRmtZcURvRkFDNkVtelNDZ3RFaXNCUGEyM2FmOVdpS3hGY2Z0Y2hwYVZz?= =?utf-8?B?ZlRycUhheUtkQnBmOTBnbkhTU3JqdHZsSkozRTNuWjJLdDFYTjhKOUhUU3gx?= =?utf-8?B?TUo3cFR2ZElxQmZFeHUxMDQ0VlI5Ti84R0xFOEMyaWRRbmsva1RiNjN3ZHht?= =?utf-8?B?K0ppdmJkZkdGb3B5Q0ZLK2puT0VaOFg3K1R0TmVad0FtcnRDTHNTTmlERDl2?= =?utf-8?B?WXQxeFhnZzJtcTZoMlhmSkRKMVdnbDRmZTFjT2pLQWsxdVgzbVZvKzIxSWFM?= =?utf-8?B?TndjMTdOMjJYWkxkS2xnTElPNWRtVjhhcG8yZ0tLOWIwQWR3bVVJb1EzV2do?= =?utf-8?B?TlgzWVVSdWlYQ0l5VlJ0Rk94aExCTnhVV0h1RkJjVU5MdC95aytSa2JmTVpB?= =?utf-8?B?YUdySmZUZlNDRGJPSWxNeHJkdXNLN0hQK1BIQVcyUFRDOXVlVzhBdFpPSXpw?= =?utf-8?B?aXJJVXJvWitKZjRya0VwVzlWVVdndnc5VnR0VnZCaHJ6WUdQMWNQZXVWbnZr?= =?utf-8?B?VUNhMDY0V0dqMHA0RmtSbFZqOG0wOUtLV2lCMFdEdVBBZTFseUIxbVRKYkpr?= =?utf-8?B?YmozQXQ2VXVjTldDK2RzK1UvLzRyNmVxaXEvSklzY2Vzb3cxWFBiSnJCOWpN?= =?utf-8?B?bElMSHh4VEFCZWFKa2FoQTlRWlJ0dS8vaVo1Kzg2bSt1YlpBVkt0ai9yREc0?= =?utf-8?B?REEyb1lKY05WNjNhNTRLMWhsUWJFcWVNS2ZQQzYrUHUxNzBsUkhoRys4dkxK?= =?utf-8?B?aThYbHI2OTc1SmtaWG5QT0xDY0RZZ2lXdDJnS1gxL0FOMGN6Z3F4YXR6RnJm?= =?utf-8?B?Q0dOQWJhaXFTWGhDTjhUTkFMVExpMUpxL3dOREhXcEhna0p1a04vcGt4WUxD?= =?utf-8?B?VkhkTzB0TGNlYkxTeDBqYUs3TlN4c1E3UW1oaGRWV2FMWUJtOWJVdkZBSm94?= =?utf-8?B?VmE2TWVacXprOFdPRkFWcnpreHFGMld6bHM5YnhmbmpEWFNZWm85VzdYRjVh?= =?utf-8?B?KzdCZnhGcHBLYzJKUUtNOHF4QTdUQTJnc0pNcEdGREtnVzgxcHpXNkpqWWpC?= =?utf-8?Q?yzCQgG?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB2825; 6:N0ANT/M1gGFnARs69A8uHp57lcBBHaI9iLXfCOIwOpoJhqx6ADt9Frqx05LuqxWk6RywTRgWIcq1LL771QSeMsNNT8hMCADkQAPtax/r6fS4ZDnI+b0D5N7OeMTt8LZBf5+9AhI+fJn4NJEzZ7Oo7heMLinMLdJYhSk4XOm3AjQoTZMCl6sTAb9YE46fsFDdRWCshR/w7NzeKvI1Rx4LLZx7h7tzY4PKh5Pj4/N5VshxyUwe5CzI+0OLMfVZoGz3PWLjLnzKZQ/nG+ou9YiZySkKHrlT49UFxpkcOBvmLa5xLfIY91Oh7ycA1DaL7BjwhXGKMc8D0mJ6JWcPnIFapKnRtDoPY4O+fX0kwSf6eq8=; 5:nE/qxjFX1ui591cxElFOTkhtGM2IK+mj4yCLNR5L9Z1BbFqmMvZuQl3whaY5EgPh0bcefysCf42DtyCG0l93szUnxiuosDQCVppSC/VvJJFE4CTC+JVYnLD69SskKBPLyc2i4Gi9AfGknWX5j2n1nOeVWoecT5NJAZarfAnCKlQ=; 24:4WnGupNt4tAOZcKCj4mNy07VF7JXuLkKLrOk/VF1ya8HJ4RpwJ4FPo+cUR614SNi0LPMJHiwVtZsK9a88pBhSxa9GP9E7b5dZc++JvFOnUE=; 7:9mM+rNf9YeuiUUtapjmMOaJfYmGJTxVrCExP+eR+Gs2ToDq6m+UWE48Tm/fIhasXbag2JvEeTsxztgo51tr0k3CoJPwnipFjV4OVjxxuHWs/6qkr35jn5A7gb8Bu29PkwEcaVXzgad4p0FLggZR7eT1ZyOEZX+h/k35qZ+i6FAt8qUZXLI0PiQByM2t6RSFCcjbj4PtM1/uf4Ns2Ueac+SxhN1Maq8kV3nx2PU5ryL4ktF2Cr93ljo6LZF8/KZHK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB2825; 20:ZqzxcPNwQbm2sn+rMfH8MfUdXTIxaZs3sMU0EP/FomiwwuedyfC5IxmG8O+Iq8zqinEtq7AWo71M17Cp2vHt0FNXoOFOYxujBfiidsSsdxl0pgcLiok2wCcyzhILc85e6yB03IAk7bdsJqeGnK+zCyJninhcbWjX2ygq+7zHTCM= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2017 16:51:42.3321 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dcb2c82-0680-4e75-8767-08d53b374bff X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2825 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/04/2017 07:20 PM, Paul Lawrence wrote: > > > +   # -fasan-shadow-offset fails without -fsanitize > > +   CFLAGS_KASAN_SHADOW := $(call cc-option, -fsanitize=kernel-address \ > > +                     -fasan-shadow-offset=$(KASAN_SHADOW_OFFSET), \ > > +                     $(call cc-option, -fsanitize=kernel-address \ > > +                     -mllvm -asan-mapping-offset=$(KASAN_SHADOW_OFFSET))) > > + > > +   ifeq ("$(CFLAGS_KASAN_SHADOW)"," ") > > This not how it was in my original patch. Why you changed this? > Condition is always false now, so it breaks kasan with 4.9.x gcc. > > > ​I had the opposite problem - CFLAGS_KASAN_SHADOW is always at least a space, and the > original condition would always be false, which is why I changed it.​ On investigation, I found  > that if the line was split it would always be a space - $(false,whatever,empty-string) would be > truly empty, but if the line was split after the second comma it would be one space. Is this a > difference in our make systems? I dunno, but it could be. Anyways, does the fixup bellow works for you? --- scripts/Makefile.kasan | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan index 7c00be9216f4..d5a1a4b6d079 100644 --- a/scripts/Makefile.kasan +++ b/scripts/Makefile.kasan @@ -24,7 +24,7 @@ else $(call cc-option, -fsanitize=kernel-address \ -mllvm -asan-mapping-offset=$(KASAN_SHADOW_OFFSET))) - ifeq ("$(CFLAGS_KASAN_SHADOW)"," ") + ifeq ($(strip $(CFLAGS_KASAN_SHADOW)),) CFLAGS_KASAN := $(CFLAGS_KASAN_MINIMAL) else # Now add all the compiler specific options that are valid standalone