diff mbox series

[v2] modules_install: make missing $DEPMOD a warning instead of error

Message ID 61369202-8425-4cb7-aa9d-b83f15c528e0@infradead.org (mailing list archive)
State New, archived
Headers show
Series [v2] modules_install: make missing $DEPMOD a warning instead of error | expand

Commit Message

Randy Dunlap Aug. 23, 2018, 5:52 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

When $DEPMOD is not found, only print a warning instead of exiting
with an error message and error status.

Warning: 'make modules_install' requires /sbin/depmod. Please install it.
This is probably in the kmod package.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
v2: add missing "exit 0" and update the commit message (no Error).

 scripts/depmod.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Greg KH Aug. 23, 2018, 5:59 p.m. UTC | #1 
On Thu, Aug 23, 2018 at 10:52:39AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> When $DEPMOD is not found, only print a warning instead of exiting
> with an error message and error status.
> 
> Warning: 'make modules_install' requires /sbin/depmod. Please install it.
> This is probably in the kmod package.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> v2: add missing "exit 0" and update the commit message (no Error).

You need a cc: stable in here too :(
diff mbox series

Patch

--- lnx-418.orig/scripts/depmod.sh
+++ lnx-418/scripts/depmod.sh
@@ -15,9 +15,9 @@  if ! test -r System.map ; then
 fi
 
 if [ -z $(command -v $DEPMOD) ]; then
-	echo "'make modules_install' requires $DEPMOD. Please install it." >&2
+	echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
 	echo "This is probably in the kmod package." >&2
-	exit 1
+	exit 0
 fi
 
 # older versions of depmod require the version string to start with three