From patchwork Wed Mar 4 06:44:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 5930641 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ECC79BF440 for ; Wed, 4 Mar 2015 06:45:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0C428203B4 for ; Wed, 4 Mar 2015 06:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECB48200F2 for ; Wed, 4 Mar 2015 06:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758449AbbCDGo6 (ORCPT ); Wed, 4 Mar 2015 01:44:58 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36619 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758180AbbCDGo4 (ORCPT ); Wed, 4 Mar 2015 01:44:56 -0500 Received: by widem10 with SMTP id em10so28206149wid.1; Tue, 03 Mar 2015 22:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=KlMoGKZw35OERcgQVmN8CCimvsQpeORK7yIyT2liNoA=; b=1FeqiMAXEW8/KIU40Jn+RJbbuvfhZh1S7W9wGfl0OAQDtgK3e02bbR7RZ85BOWogvw N4+NRLADrlxlSIyE5yrEnIjNf/gKgtuwfwRfAZNLH7rgZ8ZUe1fTIfXYCTjSNu+7HngP Vi43/rWxQLNhfcZV3+s6hqK3fex90JTxYgl2roKkRNtcOL9kwdeE38JVLY2OXOEZsIc4 wA9dxrmBpeNS5ziB4WqFzonUwx0GrrmjMdb3/t1sMpfm1wk/eRXCadMyWtAwxzBIAs7/ 9dML2I7//UDT6Efoq6nhYnNmn/iaxsWiGQCvzh7gmBPi8gXskose/SmqWLQ1yNL9ph8L twBQ== MIME-Version: 1.0 X-Received: by 10.180.86.227 with SMTP id s3mr52991594wiz.58.1425451494153; Tue, 03 Mar 2015 22:44:54 -0800 (PST) Received: by 10.27.132.68 with HTTP; Tue, 3 Mar 2015 22:44:53 -0800 (PST) Reply-To: sedat.dilek@gmail.com In-Reply-To: <20150206155009.GA23394@kroah.com> References: <20150206155009.GA23394@kroah.com> Date: Wed, 4 Mar 2015 07:44:53 +0100 Message-ID: Subject: =?UTF-8?B?UmU6IGxpbnV4LTMuMTgueTogQWRkICJrY29uZmlnOiBGaXggd2FybmluZyAi4oCYanVtcA==?= =?UTF-8?B?4oCZIG1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQiIg==?= From: Sedat Dilek To: Greg Kroah-Hartman Cc: =?UTF-8?Q?Peter_K=C3=BCmmel?= , Michal Marek , linux-kbuild@vger.kernel.org, LKML Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Feb 6, 2015 at 4:50 PM, Greg Kroah-Hartman wrote: > On Fri, Feb 06, 2015 at 04:40:28PM +0100, Sedat Dilek wrote: >> Hi, >> >> I see the following... >> >> $ yes "" | make oldconfig && make silentoldconfig > HOSTCC scripts/basic/fixdep >> HOSTCC scripts/kconfig/conf.o >> SHIPPED scripts/kconfig/zconf.tab.c >> SHIPPED scripts/kconfig/zconf.lex.c >> SHIPPED scripts/kconfig/zconf.hash.c >> HOSTCC scripts/kconfig/zconf.tab.o >> In file included from scripts/kconfig/zconf.tab.c:2537:0: >> scripts/kconfig/menu.c: In function ‘get_symbol_str’: >> scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used >> uninitialized in this function [-Wmaybe-uninitialized] >> jump->offset = strlen(r->s); >> ^ >> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here >> struct jump_key *jump; >> ^ >> HOSTLD scripts/kconfig/conf >> scripts/kconfig/conf --oldconfig Kconfig >> # >> # configuration written to .config >> # >> scripts/kconfig/conf --silentoldconfig Kconfig >> >> The fix is "kconfig: Fix warning "‘jump’ may be used uninitialized"" upstream. > > > Sure, what's the git commit id of the patch in Linus's tree? That's > annoying to me as well, thanks for reminding me about it. > Yesterday, I played with llvmlinux and this patch is also required for Linux v3.10.y. Checking for "Peter Kümmel" shows no hits. commit 2d560306096739e2251329ab5c16059311a151b0 upstream "kconfig: Fix warning "‘jump’ may be used uninitialized"" The patch needs some adaptation to fit. Unfortunately, I cannot add a "3.10" to the subject-line as it is "UTF-8-truncated" (see attached file). Shall I resend w/ all CCs and how can I fix the subject-line? - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/?h=linux-3.10.y&qt=grep&q=Peter+K%C3%BCmmel From 683b07dc2061ca8d4086d3480ca86cc9dad892c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20K=C3=BCmmel?= Date: Tue, 4 Nov 2014 12:01:59 +0100 Subject: [PATCH] =?UTF-8?q?kconfig:=20Fix=20warning=20"=E2=80=98jump?= =?UTF-8?q?=E2=80=99=20may=20be=20used=20uninitialized"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Warning: In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c: In function ‘get_symbol_str’: scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized] jump->offset = strlen(r->s); Simplifies the test logic because (head && local) means (jump != 0) and makes GCC happy when checking if the jump pointer was initialized. Signed-off-by: Peter Kümmel Signed-off-by: Michal Marek --- [ dileks: v2: Backported to fit v3.10 ] scripts/kconfig/menu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index fd3f0180e08f..6af1c42a9cf3 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -525,7 +525,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, { int i, j; struct menu *submenu[8], *menu, *location = NULL; - struct jump_key *jump; + struct jump_key *jump = NULL; str_printf(r, _("Prompt: %s\n"), _(prop->text)); menu = prop->menu->parent; @@ -563,7 +563,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, str_printf(r, _(" Location:\n")); for (j = 4; --i >= 0; j += 2) { menu = submenu[i]; - if (head && location && menu == location) + if (jump && menu == location) jump->offset = r->len - 1; str_printf(r, "%*c-> %s", j, ' ', _(menu_get_prompt(menu))); -- 2.3.1