From patchwork Tue Jun 10 08:15:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fathi Boudra X-Patchwork-Id: 4327081 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 243D69F390 for ; Tue, 10 Jun 2014 08:15:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5395120272 for ; Tue, 10 Jun 2014 08:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66B0D2026C for ; Tue, 10 Jun 2014 08:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751010AbaFJIP2 (ORCPT ); Tue, 10 Jun 2014 04:15:28 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:42713 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbaFJIPZ (ORCPT ); Tue, 10 Jun 2014 04:15:25 -0400 Received: by mail-lb0-f169.google.com with SMTP id s7so3744567lbd.0 for ; Tue, 10 Jun 2014 01:15:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ncNFEqHKuy0Iysw+tfvOGLRGlAtfBU6TjmlobE/9/ug=; b=cMCzRjnXobs3Qk9PH0EePr7sL3ZKKDup/axKYLnCYL6YKfr3NiBn1eX2DNQLt2TB9L gIf84MOqh9aHQ5hzxOkCxbbovXpSye608RP2T1CtMu1l2vVYiqg/hQx+2p2O96jRIsQm LZ9vE4SmPxCAkuf9krkIEGMbpkYOIZHqsX9HCZ43DAB+wXpwPWdyUrt1iN4lj35Hpf4u AG4XvJSDRi6iQ7D+JohyvJlUQx5pkQYWZ2CZusuCoNuWbK1BsBU73oWM2BSvwYiw4l0N fIbwE56XpXf2BWZeHNT3QsqWJDQL2C/9KxKpTBXPIkimFL4lVe7xzwSf5vZFQ1AiBXSn lGjQ== X-Gm-Message-State: ALoCoQmxnq1s8vbQBnzgNBR7Aa8Sz9oOJGyDDU6i2v7LvoCF2eMGUCd41K3BRMhK0sbQyulWjIjC MIME-Version: 1.0 X-Received: by 10.152.4.201 with SMTP id m9mr1002724lam.50.1402388123534; Tue, 10 Jun 2014 01:15:23 -0700 (PDT) Received: by 10.112.21.38 with HTTP; Tue, 10 Jun 2014 01:15:23 -0700 (PDT) In-Reply-To: <1402272928.23860.55.camel@deadeye.wl.decadent.org.uk> References: <1397307186-3977-1-git-send-email-fathi.boudra@linaro.org> <1397307186-3977-2-git-send-email-fathi.boudra@linaro.org> <1397395563.10849.79.camel@deadeye.wl.decadent.org.uk> <1402272928.23860.55.camel@deadeye.wl.decadent.org.uk> Date: Tue, 10 Jun 2014 11:15:23 +0300 Message-ID: Subject: Re: [PATCH v2 1/1] builddeb: add arm64 in the supported architectures From: Fathi Boudra To: Ben Hutchings Cc: linux-kbuild , Michal Marek , Maximilian Attems , Ian Campbell Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 9 June 2014 03:15, Ben Hutchings wrote: > On Sun, 2014-04-13 at 14:26 +0100, Ben Hutchings wrote: >> On Sat, 2014-04-12 at 15:53 +0300, Fathi Boudra wrote: >> > Signed-off-by: Fathi Boudra >> >> Reviewed-by: Ben Hutchings >> >> > --- >> > scripts/package/builddeb | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb >> > index f46e4dd..0bf29a6 100644 >> > --- a/scripts/package/builddeb >> > +++ b/scripts/package/builddeb >> > @@ -42,6 +42,8 @@ create_package() { >> > debarch=hppa ;; >> > mips*) >> > debarch=mips$(grep -q CPU_LITTLE_ENDIAN=y $KCONFIG_CONFIG && echo el || true) ;; >> > + arm64) > > Now I'm not so sure. As we are comparing with the 'machine' name > ($UTS_MACHINE, not $ARCH or $SRCARCH), shouldn't this actually check for > aarch64? not sure. I've seen Ian comment (added to the cc list). He's proposing: [...] [...] I'm taking a closer look now. > Ben. > >> > + debarch=arm64 ;; >> > arm*) >> > debarch=arm$(grep -q CONFIG_AEABI=y $KCONFIG_CONFIG && echo el || true) ;; >> > *) >> > > -- > Ben Hutchings > One of the nice things about standards is that there are so many of them. --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -28,7 +28,7 @@ create_package() { # Attempt to find the correct Debian architecture local forcearch="" debarch="" case "$UTS_MACHINE" in - i386|ia64|alpha) + i386|ia64|alpha|arm64) debarch="$UTS_MACHINE" ;; x86_64) debarch=amd64 ;;