From patchwork Tue Oct 17 17:54:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 10012665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D892060235 for ; Tue, 17 Oct 2017 17:54:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA49A289AF for ; Tue, 17 Oct 2017 17:54:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BEE76289B6; Tue, 17 Oct 2017 17:54:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14AEA289AF for ; Tue, 17 Oct 2017 17:54:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757947AbdJQRy5 (ORCPT ); Tue, 17 Oct 2017 13:54:57 -0400 Received: from merlin.infradead.org ([205.233.59.134]:45580 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbdJQRy4 (ORCPT ); Tue, 17 Oct 2017 13:54:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4o9TOhNXF7AELNBjf4yj2ToWCzlA7o27IEM6Q2qx8fk=; b=TlCkCgtn04PirBdQHiwKeM776g ODLUcb0sRAR7+fc8lTXBvoS2lf1+7SjgxYqI4sX26ZGeTNIEYGmde3eW8X1sLjwckDalmjJaYvj/K iT5AijkF1ptp6jWHrzNRIsZpj6y/yA4DEJS0smBTkgut0O96v49g/QPkwQXRmZNOciA6O1En6C3sd 4c5Q8AJlCz+ODszp7FlSkEVz9vk1EKUsgCUUcYhXJIoxWlSNkTkglS8PunpX1kORaWSr7C2eyHCEg BUqcEWLX9VV7B3HKxwLbXMe4n1IEGQZpsrIpibxafrsFI4j9neFY22/gbhlMxzPyrJZbKe9noVa3Z 1EUMKDmQ==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlap) by merlin.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1e4W4s-0002Vt-AN; Tue, 17 Oct 2017 17:54:54 +0000 Subject: Re: [PATCH] Makefile: add targets for config-help and pkg-help To: Shuah Khan , yamada.masahiro@socionext.com Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek References: <20171017151848.3087-1-shuahkh@osg.samsung.com> From: Randy Dunlap Message-ID: Date: Tue, 17 Oct 2017 10:54:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171017151848.3087-1-shuahkh@osg.samsung.com> Content-Language: en-US Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 10/17/17 08:18, Shuah Khan wrote: > Change to enable config help and package help from the main make level > to make it easier to use. It has become difficult to find config help > and pkg help specific output from the "help" information. > > Signed-off-by: Shuah Khan > --- > Makefile | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Makefile b/Makefile > index 46bfb0ed2257..1d6f86df1b6c 100644 > --- a/Makefile > +++ b/Makefile > @@ -1441,6 +1441,13 @@ help: > @echo 'Execute "make" or "make all" to build all targets marked with [*] ' > @echo 'For further info see the ./README file' > > +PHONY += config-help > +config-help: > + @$(MAKE) -f $(srctree)/scripts/kconfig/Makefile help > + > +PHONY += pkg-help > +pkg-help: > + @$(MAKE) $(build)=$(package-dir) help > > help-board-dirs := $(addprefix help-,$(board-dirs)) > > Hi, It now looks like we need these help sub-options listed somewhere, like the patch below. Also, it would be very nice if we could use 'make help' without running 'make silentoldconfig' and/or expecting a .config file to be present. As it is, we get all of this noise before seeing the config-help: (but this is a separate issue IMO) rdunlap@midway:lnx-414-rc5> make ARCH=um O=UM64 config-help make[1]: Entering directory '/local/lnx/kernel/lnx-414-rc5/UM64' GEN ./Makefile scripts/kconfig/conf --silentoldconfig arch/x86/um/Kconfig *** *** Configuration file ".config" not found! *** *** Please run some configurator (e.g. "make oldconfig" or *** "make menuconfig" or "make xconfig"). *** ../scripts/kconfig/Makefile:37: recipe for target 'silentoldconfig' failed make[3]: *** [silentoldconfig] Error 1 ../Makefile:547: recipe for target 'silentoldconfig' failed make[2]: *** [silentoldconfig] Error 2 config - Update current config utilising a line-oriented program nconfig - Update current config utilising a ncurses menu based program For your patch: Acked-by: Randy Dunlap Tested-by: Randy Dunlap If you want to, you can fold the patch below into your patch. --- From: Randy Dunlap Add info on "make help" sub-targets "make config-help" and "make pkg-help". References to "make dochelp" and "make kselftest-help" etc. can also be added. Or a few lines could be added to the end of the "make help" output, but I think that it is too long already. Signed-off-by: Randy Dunlap --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- lnx-414-rc5.orig/Makefile +++ lnx-414-rc5/Makefile @@ -1359,7 +1359,7 @@ help: @echo ' mrproper - Remove all generated files + config + various backup files' @echo ' distclean - mrproper + remove editor backup and patch files' @echo '' - @echo 'Configuration targets:' + @echo 'Configuration targets: (or use "make config-help")' @$(MAKE) -f $(srctree)/scripts/kconfig/Makefile help @echo '' @echo 'Other generic targets:' @@ -1406,7 +1406,7 @@ help: @echo ' use "make tools/help"' @echo ' or "cd tools; make help"' @echo '' - @echo 'Kernel packaging:' + @echo 'Kernel packaging: (or use "make pkg-help")' @$(MAKE) $(build)=$(package-dir) help @echo '' @echo 'Documentation targets:'