| Message ID | e84eeeecde70ecb3ab82c5f825fec359f9e967ff.1419387513.git.shuahkh@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 24 Dec 2014 09:27:41 -0700 Shuah Khan <shuahkh@osg.samsung.com> wrote: > Add a new make target to enable installing test. This target > installs test in the kselftest install location and add to the > kselftest script to run the test. Install target can be run > only from top level kernel source directory. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/ftrace/Makefile | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile > index 76cc9f1..7c7cf42 100644 > --- a/tools/testing/selftests/ftrace/Makefile > +++ b/tools/testing/selftests/ftrace/Makefile > @@ -1,7 +1,16 @@ > +TEST_STR = /bin/sh ./ftracetest || echo ftrace selftests: [FAIL] Is it ok that this removes the quotes around the echo string? I don't see anything wrong about it, but I don't know if there's a shell out there that will fail due to it. Other than than, Acked-by: Steven Rostedt <rostedt@goodmis.org> -- Steve > + > all: > > +install: > +ifdef INSTALL_KSFT_PATH > + install ./ftracetest $(INSTALL_KSFT_PATH) > + @cp -r test.d $(INSTALL_KSFT_PATH) > + echo "$(TEST_STR)" >> $(KSELFTEST) > +endif > + > run_tests: > - @/bin/sh ./ftracetest || echo "ftrace selftests: [FAIL]" > + @$(TEST_STR) > > clean: > rm -rf logs/* -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
(2015/01/03 0:45), Steven Rostedt wrote: > On Wed, 24 Dec 2014 09:27:41 -0700 > Shuah Khan <shuahkh@osg.samsung.com> wrote: > >> Add a new make target to enable installing test. This target >> installs test in the kselftest install location and add to the >> kselftest script to run the test. Install target can be run >> only from top level kernel source directory. >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/ftrace/Makefile | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile >> index 76cc9f1..7c7cf42 100644 >> --- a/tools/testing/selftests/ftrace/Makefile >> +++ b/tools/testing/selftests/ftrace/Makefile >> @@ -1,7 +1,16 @@ >> +TEST_STR = /bin/sh ./ftracetest || echo ftrace selftests: [FAIL] > > Is it ok that this removes the quotes around the echo string? I don't > see anything wrong about it, but I don't know if there's a shell out > there that will fail due to it. Agreed, if possible, we'd better add quotes around the echo string as you did in 2/20 in this series. Anyway, you can also add my ack to this patch. Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Thank you! > > Other than than, > > Acked-by: Steven Rostedt <rostedt@goodmis.org> > > -- Steve > > >> + >> all: >> >> +install: >> +ifdef INSTALL_KSFT_PATH >> + install ./ftracetest $(INSTALL_KSFT_PATH) >> + @cp -r test.d $(INSTALL_KSFT_PATH) >> + echo "$(TEST_STR)" >> $(KSELFTEST) >> +endif >> + >> run_tests: >> - @/bin/sh ./ftracetest || echo "ftrace selftests: [FAIL]" >> + @$(TEST_STR) >> >> clean: >> rm -rf logs/* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
(2015/01/03 0:45), Steven Rostedt wrote: > On Wed, 24 Dec 2014 09:27:41 -0700 > Shuah Khan <shuahkh@osg.samsung.com> wrote: > >> Add a new make target to enable installing test. This target >> installs test in the kselftest install location and add to the >> kselftest script to run the test. Install target can be run >> only from top level kernel source directory. >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/ftrace/Makefile | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile >> index 76cc9f1..7c7cf42 100644 >> --- a/tools/testing/selftests/ftrace/Makefile >> +++ b/tools/testing/selftests/ftrace/Makefile >> @@ -1,7 +1,16 @@ >> +TEST_STR = /bin/sh ./ftracetest || echo ftrace selftests: [FAIL] > > Is it ok that this removes the quotes around the echo string? I don't > see anything wrong about it, but I don't know if there's a shell out > there that will fail due to it. Agreed, if possible, we'd better add quotes around the echo string as you did in 2/20 in this series. Anyway, you can also add my ack to this patch. Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Thank you! > > Other than than, > > Acked-by: Steven Rostedt <rostedt@goodmis.org> > > -- Steve > > >> + >> all: >> >> +install: >> +ifdef INSTALL_KSFT_PATH >> + install ./ftracetest $(INSTALL_KSFT_PATH) >> + @cp -r test.d $(INSTALL_KSFT_PATH) >> + echo "$(TEST_STR)" >> $(KSELFTEST) >> +endif >> + >> run_tests: >> - @/bin/sh ./ftracetest || echo "ftrace selftests: [FAIL]" >> + @$(TEST_STR) >> >> clean: >> rm -rf logs/* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
On 01/02/2015 08:45 AM, Steven Rostedt wrote: > On Wed, 24 Dec 2014 09:27:41 -0700 > Shuah Khan <shuahkh@osg.samsung.com> wrote: > >> Add a new make target to enable installing test. This target >> installs test in the kselftest install location and add to the >> kselftest script to run the test. Install target can be run >> only from top level kernel source directory. >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/ftrace/Makefile | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile >> index 76cc9f1..7c7cf42 100644 >> --- a/tools/testing/selftests/ftrace/Makefile >> +++ b/tools/testing/selftests/ftrace/Makefile >> @@ -1,7 +1,16 @@ >> +TEST_STR = /bin/sh ./ftracetest || echo ftrace selftests: [FAIL] > > Is it ok that this removes the quotes around the echo string? I don't > see anything wrong about it, but I don't know if there's a shell out > there that will fail due to it. Right. both sh and bash are fine without the quotes. In this case there are no variables to interpret, so quotes don't do anything. I might as well play it safe. I will have to fix a few other tests to address this comment. Will generate v4s for a few tests in this series. Thanks, -- Shuah > > Other than than, > > Acked-by: Steven Rostedt <rostedt@goodmis.org> > > -- Steve > > >> + >> all: >> >> +install: >> +ifdef INSTALL_KSFT_PATH >> + install ./ftracetest $(INSTALL_KSFT_PATH) >> + @cp -r test.d $(INSTALL_KSFT_PATH) >> + echo "$(TEST_STR)" >> $(KSELFTEST) >> +endif >> + >> run_tests: >> - @/bin/sh ./ftracetest || echo "ftrace selftests: [FAIL]" >> + @$(TEST_STR) >> >> clean: >> rm -rf logs/* >
diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile index 76cc9f1..7c7cf42 100644 --- a/tools/testing/selftests/ftrace/Makefile +++ b/tools/testing/selftests/ftrace/Makefile @@ -1,7 +1,16 @@ +TEST_STR = /bin/sh ./ftracetest || echo ftrace selftests: [FAIL] + all: +install: +ifdef INSTALL_KSFT_PATH + install ./ftracetest $(INSTALL_KSFT_PATH) + @cp -r test.d $(INSTALL_KSFT_PATH) + echo "$(TEST_STR)" >> $(KSELFTEST) +endif + run_tests: - @/bin/sh ./ftracetest || echo "ftrace selftests: [FAIL]" + @$(TEST_STR) clean: rm -rf logs/*
Add a new make target to enable installing test. This target installs test in the kselftest install location and add to the kselftest script to run the test. Install target can be run only from top level kernel source directory. Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/ftrace/Makefile | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)