From patchwork Mon Oct 17 22:32:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 9380811 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 076FC6086B for ; Mon, 17 Oct 2016 22:32:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3DBD28CEF for ; Mon, 17 Oct 2016 22:32:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E864828EFE; Mon, 17 Oct 2016 22:32:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 577F128CEF for ; Mon, 17 Oct 2016 22:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310AbcJQWcc (ORCPT ); Mon, 17 Oct 2016 18:32:32 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34037 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932163AbcJQWcb (ORCPT ); Mon, 17 Oct 2016 18:32:31 -0400 Received: from static-50-53-43-78.bvtn.or.frontiernet.net ([50.53.43.78] helo=[192.168.1.19]) by bombadil.infradead.org with esmtpsa (Exim 4.85_2 #1 (Red Hat Linux)) id 1bwGSM-0004ly-UN; Mon, 17 Oct 2016 22:32:31 +0000 Subject: Re: please, where has xconfig KConf option documentation gone with linux 4.8's Qt5 / Qt4 xconfig ? To: Boris Barbulovski , linux-kernel@vger.kernel.org, linux-kbuild , Jason Vas Dias References: <3077d5cb-9a8a-5d3e-cd00-ce3ad5cb3406@infradead.org> <5d04ac9f-8cf5-3f1a-4943-16dbfd24f0fc@infradead.org> From: Randy Dunlap Message-ID: Date: Mon, 17 Oct 2016 15:32:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP [adding Jason for testing] On 10/17/16 13:43, Boris Barbulovski wrote: > can you try this patch? > And make sure to delete ~/.config/kernel.org/qconf.conf file before testing because it might have some illegal settings that might trigger the same issue again. [patch is attached] > > > On Mon, Oct 17, 2016 at 7:28 PM, Randy Dunlap wrote: >> Boris or Thiago, >> >> Any comments, suggestions, or patches about this? >> >> thanks. >> >> On 10/15/16 04:09, Jason Vas Dias wrote: >>> Aha, thanks! I never would have known this without being told - >>> there is no visible indication that the symbol info pane exists >>> at all until one tries to drag the lower right corner of the window >>> notth-eastwards - is this meant to be somehow an intuitive thing to >>> do these days to view more info ? >>> >>> I did manage to view the option documentation with nconfig / >>> using emacs to view the KConf files (preferable). >>> >>> Really, it would be nice if xconfig had some 'View' Menu & one could select >>> View -> Option Documentation or press over an option to view the >>> documentation for it , and if the geometry of the different panes was >>> correct at >>> startup .- the whole Option value pane initially appears on the far right hand >>> side, about 10 pixels wide , until resized ; and there really is no sign of the >>> documentation pane at all until lower right-hand corner dragged. >>> >>> Also, in the Help -> Introduction panel, it says : >>> "Toggling Show Debug Info under the Options menu will show the >>> dependencies..." >>> but there is no "Show Debug Info" option on the Options menu - sounds like >>> it might be a useful feature - should I be seeing a "Show Debug Info" option ? >>> why don't I see one ? Maybe the Options menu might be a good place to put >>> an "Expand Option Documentation Pane" option ? >>> >>> Thanks anyway for the info. >>> >>> Regards, >>> Jason >>> >>> >>> >>> >>> On 11/10/2016, Randy Dunlap wrote: >>>> [changed linux-config to linux-kbuild list] >>>> >>>> On 10/09/16 13:46, Jason Vas Dias wrote: >>>>> Hi - >>>>> I've been doing 'make xconfig' to configure the kernel for many years >>>>> now, and >>>>> always there used to be some option documentation pane populated with >>>>> summary documentation for the specific option selected . >>>>> But now, when built for Qt 5.7.0, (also tried Qt 4.8 and GTK) there >>>>> is no option >>>>> documentation pane - this is a real pain ! The option documentation also >>>>> is not displayed with any other gui, eg. 'make menuconfig' / 'make >>>>> gtkconfig' - >>>>> I'm sure it used to be . This is a regression IMHO . >>>>> How can I restore display of documentation for each selected option ? >>>>> Will older xconfig work for Linux 4.8 ? it appears not ... >>>>> Thanks in advance for any replies, >>>>> Jason >>>> >>>> That's odd. I see the help info in all of xconfig, gconfig, menuconfig, & >>>> nconfig. >>>> >>>> In xconfig, if the right hand side of the config window only lists some >>>> kernel config >>>> options and no symbol help/info, the symbol info portion may be hidden. Try >>>> pointing >>>> to the bottom of the right side of the window and hold down the left mouse >>>> button >>>> and then drag the mouse pointer upward to open the symbol info pane. >>>> At least that is what works for me. >>>> >>>> -- >>>> ~Randy >> >> >> -- >> ~Randy > > > From 75350fa3ec1dd925a30b2511892128a07cbe10de Mon Sep 17 00:00:00 2001 From: Boris Barbulovski Date: Mon, 17 Oct 2016 22:23:14 +0200 Subject: [PATCH] qconfig initial slider sizes fix. On first `make xconfig`, suboption and help panels were hidden. Now we properly detect the first run, and show those panels. Signed-off-by: Boris Barbulovski --- scripts/kconfig/qconf.cc | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index fc55559..e99c04f 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -65,11 +65,19 @@ ConfigSettings::ConfigSettings() QList ConfigSettings::readSizes(const QString& key, bool *ok) { QList result; - QStringList entryList = value(key).toStringList(); - QStringList::Iterator it; - for (it = entryList.begin(); it != entryList.end(); ++it) - result.push_back((*it).toInt()); + if (contains(key)) + { + QStringList entryList = value(key).toStringList(); + QStringList::Iterator it; + + for (it = entryList.begin(); it != entryList.end(); ++it) + result.push_back((*it).toInt()); + + *ok = true; + } + else + *ok = false; return result; } -- 2.7.4