diff mbox

[1/2] xconfig: fix 'Show Debug' functionality

Message ID fb990a5d-c9c5-5b37-0e59-d5df19f64c67@infradead.org (mailing list archive)
State New, archived
Headers show

Commit Message

Randy Dunlap Nov. 30, 2016, 10:57 p.m. UTC 
From: Boris Barbulovski <bbarbulovski@gmail.com>

xconfig - Fix missing 'Show Debug' functionality.

xconfig Help mentions 'Show Debug Info' but it was missing from any
menu.

* Add 'Show debug' menu to the main menu.
* Properly load showDebug settings.

Reported-by: Jason Vas Dias <jason.vas.dias@gmail.com>
Signed-off-by: Boris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
---
 scripts/kconfig/qconf.cc |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Boris asked me to push these 2 patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Michal Marek Dec. 11, 2016, 8:42 p.m. UTC | #1 
On Wed, Nov 30, 2016 at 02:57:52PM -0800, Randy Dunlap wrote:
> From: Boris Barbulovski <bbarbulovski@gmail.com>
> 
> xconfig - Fix missing 'Show Debug' functionality.
> 
> xconfig Help mentions 'Show Debug Info' but it was missing from any
> menu.
> 
> * Add 'Show debug' menu to the main menu.
> * Properly load showDebug settings.
> 
> Reported-by: Jason Vas Dias <jason.vas.dias@gmail.com>
> Signed-off-by: Boris Barbulovski <bbarbulovski@gmail.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>

Applied to kbuild.git#kconfig.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- lnx-49-rc7.orig/scripts/kconfig/qconf.cc
+++ lnx-49-rc7/scripts/kconfig/qconf.cc
@@ -1014,7 +1014,7 @@  ConfigInfoView::ConfigInfoView(QWidget*
 
 	if (!objectName().isEmpty()) {
 		configSettings->beginGroup(objectName());
-		_showDebug = configSettings->value("/showDebug", false).toBool();
+		setShowDebug(configSettings->value("/showDebug", false).toBool());
 		configSettings->endGroup();
 		connect(configApp, SIGNAL(aboutToQuit()), SLOT(saveSettings()));
 	}
@@ -1474,6 +1474,7 @@  ConfigMainWindow::ConfigMainWindow(void)
 	optionMenu->addSeparator();
 	optionMenu->addActions(optGroup->actions());
 	optionMenu->addSeparator();
+	optionMenu->addAction(showDebugAction);
 
 	// create help menu
 	menu->addSeparator();