From patchwork Thu Oct 3 13:13:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dirk Gouders X-Patchwork-Id: 2982791 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 316D29F289 for ; Thu, 3 Oct 2013 13:13:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 30E87202E8 for ; Thu, 3 Oct 2013 13:13:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90449202E5 for ; Thu, 3 Oct 2013 13:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421Ab3JCNNT (ORCPT ); Thu, 3 Oct 2013 09:13:19 -0400 Received: from services.gouders.net ([141.101.32.176]:51653 "EHLO services.gouders.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752347Ab3JCNNS (ORCPT ); Thu, 3 Oct 2013 09:13:18 -0400 Received: from localhost (ip-109-44-3-244.web.vodafone.de [109.44.3.244]) (authenticated bits=0) by services.gouders.net (8.14.7/8.14.7) with ESMTP id r93DC7oc016661 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Oct 2013 15:12:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gouders.net; s=gnet; t=1380805936; bh=GFB8HwyHVHimihKs8jnsEwfSDc+2i7aNAAT3OpRleQ0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=jlf4JxPiv+qck3CT7k/Y5oa8ojuHZTDl7iXSsAeBNzuiwJSp4tUj/OCZ8pPz+QVDs 90Pm8uRGhXjX8I460tmNVeXVScIA70HyjIsZ0GRMdF6/Co315El1gKP/WXjwo7Dc2b KqeTMierjzQeT34xDeu9rftUJ/73eLCFLWia40ME= From: Dirk Gouders To: Martin Walch Cc: "Yann E. MORIN" , linux-kbuild@vger.kernel.org, Michal Marek , Jiri Kosina , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Benjamin Poirier , Wang YanQing , Andrew Morton , Jean Delvare , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] kconfig: remove unused definition from scanner In-Reply-To: <1491733.iNaKkFyqph@tacticalops> (Martin Walch's message of "Thu, 03 Oct 2013 02:30:21 +0200") References: <6249343.9Mjtul3lu5@tacticalops> <201310020857.54800.yann.morin.1998@free.fr> <1491733.iNaKkFyqph@tacticalops> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) Date: Thu, 03 Oct 2013 15:13:09 +0200 Message-ID: MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_ADSP_DISCARD, DKIM_SIGNED, KHOP_BIG_TO_CC, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, T_TVD_MIME_EPI, T_TVD_MIME_NO_HEADERS, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Martin Walch writes: > On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote: >> On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote: >> > I think you should also regenerate the scanner and add >> > the new zconf.lex.c_shipped to this patch. >> >> I think sending the re-generated parser as a separate patch helps >> in reviewing. Ie. I'd prefer a fifth patch. >> >> BTW, regenerating the parser can be done with: >> make REGENERATE_PARSERS=1 config > > Actually, I regenerated the scanner. However, the results did not change > after applying the patch, because the definition that the patch removes > (ws) is not used anywhere. It is only a cleanup. Sorry, my review was too superficial. I did downgrade my flex to see if your changes affect the scanner, but I did not test it without your patch and also did not have a look in what the changes are. The changes I noticed here are probably related to the flex package I use (on a Gentoo system) -- they even occur without your patch. I'll attach what I noticed in case someone is interested. Dirk diff --git a/scripts/kconfig/zconf.lex.c_shipped b/scripts/kconfig/zconf.lex.c_shipped index a0521aa..3eb4c0b 100644 --- a/scripts/kconfig/zconf.lex.c_shipped +++ b/scripts/kconfig/zconf.lex.c_shipped @@ -920,7 +920,7 @@ static int input (void ); /* This used to be an fputs(), but since the string might contain NUL's, * we now use fwrite(). */ -#define ECHO do { if (fwrite( zconftext, zconfleng, 1, zconfout )) {} } while (0) +#define ECHO fwrite( zconftext, zconfleng, 1, zconfout ) #endif /* Gets input and stuffs it into "buf". number of characters read, or YY_NULL,