From patchwork Sun Aug 20 19:54:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Palmer Dabbelt X-Patchwork-Id: 9911417 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C2A2260382 for ; Sun, 20 Aug 2017 19:54:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B298F28747 for ; Sun, 20 Aug 2017 19:54:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A409728748; Sun, 20 Aug 2017 19:54:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 896D028745 for ; Sun, 20 Aug 2017 19:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753222AbdHTTyI (ORCPT ); Sun, 20 Aug 2017 15:54:08 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33953 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbdHTTyH (ORCPT ); Sun, 20 Aug 2017 15:54:07 -0400 Received: by mail-pg0-f66.google.com with SMTP id i12so5324329pgr.1 for ; Sun, 20 Aug 2017 12:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version; bh=hMYNzhGnUXD+bmgzeaf/x7jzpLbXFylopiGIrCnWMrs=; b=u1B1BaTLKe/sAwh4icNSpkA8y/Es3cbkjAHMmRKCkg32DaVXGghkpbjufM5l3ngGo2 oGcKpIHiaI/vo1ilWRqt/icda6Uy/o+oCtGDuCmT5ccShQD0lB1YwgG4r4IxbkpwLPCx Va+RvwnAL72MPyhu6XN5AO9YiXzKTfN2x+Ylvc/o8Y9CCs1cJxpcVT+/E8a+YWEltiRo psgrCkxdJVG4J7qLvBSZDTyisCMtJCTmDqwsGtBzEvwUQ38rcNHoI05KgONjjuRc35VF cbDhD7VKTeFUjw7dW78b0oRXT3QrddNUI23A8Ht6DmVsLCqfEdfJ1D7Y80MWT/2b+wwY XtFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version; bh=hMYNzhGnUXD+bmgzeaf/x7jzpLbXFylopiGIrCnWMrs=; b=ItZHBfIZM/H9oFc5jE2vKQ23lwb3nZS77/9e78rKSW4paHovAtpVX58uRvokhj+H4A Y+/zb9u0TSy+goeNeSOfylXPImqvUq7I1NAxrH4A4SUlT/oxoZc6VdvVphoUEoZpdK0c lidXlk3oVwUt7Jn7OU8UHJ7dFQS1YKps70n2bHW3vwqwBTK0ZJckY+SUZmY3AouGQ9rJ nuCkWctgcu/JFopiFNJKJ1q7kaNBW+HUk2W3vClGUmFbGo9Gduwur137bRTeyj8XfaoU Ww7rbq2brn159V7EwMqwLdD+r8UdhCJXPOT22dMKb1rQpw3i0v8KotCCD09UOKBw9+aw h2jw== X-Gm-Message-State: AHYfb5ivGkCFMbY4JMzZzXgpyi0pzYAIo5fea3t+Yg8pk5rknVSRtL8K 4LlPPhsiGnb6YELQ X-Received: by 10.99.125.75 with SMTP id m11mr14631285pgn.427.1503258846796; Sun, 20 Aug 2017 12:54:06 -0700 (PDT) Received: from localhost ([12.206.222.2]) by smtp.gmail.com with ESMTPSA id c7sm20740738pfg.29.2017.08.20.12.54.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Aug 2017 12:54:05 -0700 (PDT) Date: Sun, 20 Aug 2017 12:54:05 -0700 (PDT) X-Google-Original-Date: Sun, 20 Aug 2017 12:44:02 PDT (-0700) Subject: Re: [PATCH v7 02/15] lib: Add shared copies of some GCC library routines In-Reply-To: <1501592780.29303.324.camel@linux.intel.com> CC: peterz@infradead.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, Arnd Bergmann , yamada.masahiro@socionext.com, mmarek@suse.com, albert@sifive.com, will.deacon@arm.com, boqun.feng@gmail.com, oleg@redhat.com, mingo@redhat.com, daniel.lezcano@linaro.org, gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org, hverkuil@xs4all.nl, rdunlap@infradead.org, viro@zeniv.linux.org.uk, mhiramat@kernel.org, fweisbec@gmail.com, mcgrof@kernel.org, dledford@redhat.com, bart.vanassche@sandisk.com, sstabellini@kernel.org, mpe@ellerman.id.au, rmk+kernel@armlinux.org.uk, paul.gortmaker@windriver.com, nicolas.dichtel@6wind.com, linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, geert@linux-m68k.org, akpm@linux-foundation.org, jiri@mellanox.com, vgupta@synopsys.com, airlied@redhat.com, jk@ozlabs.org, chris@chris-wilson.co.uk, Jason@zx2c4.com, paulmck@linux.vnet.ibm.com, ncardwell@google.com, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, patches@groups.riscv.org From: Palmer Dabbelt To: andriy.shevchenko@linux.intel.com Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 01 Aug 2017 06:06:20 PDT (-0700), andriy.shevchenko@linux.intel.com wrote: > On Mon, 2017-07-31 at 17:59 -0700, Palmer Dabbelt wrote: >> Many ports (m32r, microblaze, mips, parisc, score, and sparc) use >> functionally identical copies of various GCC library routine files, >> which came up as we were submitting the RISC-V port (which also uses >> some of these). >> >> This patch adds a new copy of these library routine files, which are >> functionally identical to the various other copies.  These are >> availiable via Kconfig as CONFIG_GENERIC_$ROUTINE, which currently >> isn't >> used anywhere. >> > > >> Signed-off-by: Palmer Dabbelt > >> Reviewed-by: Geert Uytterhoeven > >> Signed-off-by: Palmer Dabbelt > > That's why we are putting tags before own SoB line(s) OK, sorry about that -- I'll fix it for our v8 patch set. > In two cases in the patch you have > > + > + > > for no reason. I think you may remove second empty line. Makes sense. I'll squash this into the next patch set. --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/lib/libgcc.h b/include/lib/libgcc.h index a5397e34e005..32e1e0f4b2d0 100644 --- a/include/lib/libgcc.h +++ b/include/lib/libgcc.h @@ -16,7 +16,6 @@ * to the Free Software Foundation, Inc. */ - #ifndef __LIB_LIBGCC_H #define __LIB_LIBGCC_H diff --git a/lib/ashldi3.c b/lib/ashldi3.c index ff4ec63d2ab6..1b6087db95a5 100644 --- a/lib/ashldi3.c +++ b/lib/ashldi3.c @@ -14,7 +14,6 @@ * to the Free Software Foundation, Inc. */ - #include #include