| Message ID | 1582104810-12983-1-git-send-email-alan.maguire@oracle.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ftrace/selftest: clean up failure cases | expand |
Shuah, Can you take these two patches through your tree? Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve On Wed, 19 Feb 2020 09:33:28 +0000 Alan Maguire <alan.maguire@oracle.com> wrote: > When running the ftrace selftests, 2 failures and 6 unresolved > cases were observed. The failures can be avoided by setting > a sysctl prior to test execution (fixed in patch 1) and by > having unresolved cases not return 0 from ftracetest by default > since they indicate an absence of testing modules/programs > rather than ftrace issues (patch 2). > > The latter are classified as "unresolved" tests, which operate > differently from "unsupported" tests. For unsupported tests, > we note the unsupported count but do not consider the tests > as having failed, whereas with unresolved the test run is > considered to have failed so returns "not ok" when run via > kselftest ("make -C tools/testing/selftest/ftrace run_tests"). > > Patch 2 aligns the unresolved behaviour with the unsupported; > by default, unresolved outcomes do not trigger overall failure, > but they can if --fail-unresolved is specified. > > Changes since v1: > > - updated patch 1 to use /proc path instead of sysctl (Masami) > - updated patch 2 to modify unresolved handling in ftracetest > rather than change individual unresolved -> unsupported (Masami) > > Alan Maguire (2): > ftrace/selftests: workaround cgroup RT scheduling issues > ftrace/selftest: make unresolved cases cause failure if > --fail-unresolved set > > tools/testing/selftests/ftrace/ftracetest | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) >
When running the ftrace selftests, 2 failures and 6 unresolved cases were observed. The failures can be avoided by setting a sysctl prior to test execution (fixed in patch 1) and by having unresolved cases not return 0 from ftracetest by default since they indicate an absence of testing modules/programs rather than ftrace issues (patch 2). The latter are classified as "unresolved" tests, which operate differently from "unsupported" tests. For unsupported tests, we note the unsupported count but do not consider the tests as having failed, whereas with unresolved the test run is considered to have failed so returns "not ok" when run via kselftest ("make -C tools/testing/selftest/ftrace run_tests"). Patch 2 aligns the unresolved behaviour with the unsupported; by default, unresolved outcomes do not trigger overall failure, but they can if --fail-unresolved is specified. Changes since v1: - updated patch 1 to use /proc path instead of sysctl (Masami) - updated patch 2 to modify unresolved handling in ftracetest rather than change individual unresolved -> unsupported (Masami) Alan Maguire (2): ftrace/selftests: workaround cgroup RT scheduling issues ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set tools/testing/selftests/ftrace/ftracetest | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)