| Message ID | 20200318010153.40797-1-kuba@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | kselftest: add fixture parameters | expand |
On Tue, Mar 17, 2020 at 06:01:48PM -0700, Jakub Kicinski wrote: > Shuah please consider applying to the kselftest tree. Just to confirm: yes please. Shuah, I'd love to see this land. -Kees > > This set is an attempt to make running tests for different > sets of data easier. The direct motivation is the tls > test which we'd like to run for TLS 1.2 and TLS 1.3, > but currently there is no easy way to invoke the same > tests with different parameters. > > Tested all users of kselftest_harness.h. > > v2: > - don't run tests by fixture > - don't pass params as an explicit argument > > v3: > - go back to the orginal implementation with an extra > parameter, and running by fixture (Kees); > - add LIST_APPEND helper (Kees); > - add a dot between fixture and param name (Kees); > - rename the params to variants (Tim); > > v4: > - whitespace fixes. > > v5 (Kees): > - move a comment; > - remove a temporary variable; > - reword the commit message on patch 4. > > v1: https://lore.kernel.org/netdev/20200313031752.2332565-1-kuba@kernel.org/ > v2: https://lore.kernel.org/netdev/20200314005501.2446494-1-kuba@kernel.org/ > v3: https://lore.kernel.org/netdev/20200316225647.3129354-1-kuba@kernel.org/ > v4: https://lore.kernel.org/netdev/20200317010419.3268916-1-kuba@kernel.org/ > > Jakub Kicinski (5): > kselftest: factor out list manipulation to a helper > kselftest: create fixture objects > kselftest: run tests by fixture > kselftest: add fixture variants > selftests: tls: run all tests for TLS 1.2 and TLS 1.3 > > Documentation/dev-tools/kselftest.rst | 3 +- > tools/testing/selftests/kselftest_harness.h | 234 +++++++++++++++----- > tools/testing/selftests/net/tls.c | 93 ++------ > 3 files changed, 202 insertions(+), 128 deletions(-) > > -- > 2.25.1 >
On Tue, 17 Mar 2020 18:01:48 -0700 Jakub Kicinski wrote: > Hi! > > Shuah please consider applying to the kselftest tree. > > This set is an attempt to make running tests for different > sets of data easier. The direct motivation is the tls > test which we'd like to run for TLS 1.2 and TLS 1.3, > but currently there is no easy way to invoke the same > tests with different parameters. > > Tested all users of kselftest_harness.h. Hi Shuah! Were these applied anywhere? I'm happy to take them via the networking tree if that's easier.
On Fri, Apr 10, 2020 at 05:23:26PM -0700, Jakub Kicinski wrote: > On Tue, 17 Mar 2020 18:01:48 -0700 Jakub Kicinski wrote: > > Hi! > > > > Shuah please consider applying to the kselftest tree. > > > > This set is an attempt to make running tests for different > > sets of data easier. The direct motivation is the tls > > test which we'd like to run for TLS 1.2 and TLS 1.3, > > but currently there is no easy way to invoke the same > > tests with different parameters. > > > > Tested all users of kselftest_harness.h. > > Hi Shuah! > > Were these applied anywhere? I'm happy to take them via > the networking tree if that's easier. Shuah, with -rc1 out the door, would now be a good time to take this series? Thanks! -Kees