mbox series

[0/2] selftests: rtnetlink: Fix for false-negative return values

Message ID 20200804101803.23062-1-po-hsu.lin@canonical.com (mailing list archive)
Headers show
Series selftests: rtnetlink: Fix for false-negative return values | expand

Message

Po-Hsu Lin Aug. 4, 2020, 10:18 a.m. UTC
This patchset will address the false-negative return value issue
caused by the following:
  1. The return value "ret" in this script will be reset to 0 from
     the beginning of each sub-test in rtnetlink.sh, therefore this
     rtnetlink test will always pass if the last sub-test has passed.
  2. The test result from two sub-tests in kci_test_encap() were not
     being processed, thus they will not affect the final test result
     of this test.


Po-Hsu Lin (2):
  selftests: rtnetlink: correct the final return value for the test
  selftests: rtnetlink: make kci_test_encap() return sub-test result

 tools/testing/selftests/net/rtnetlink.sh | 68 +++++++++++++++++++++-----------
 1 file changed, 46 insertions(+), 22 deletions(-)

Comments

David Miller Aug. 5, 2020, 7:23 p.m. UTC | #1
From: Po-Hsu Lin <po-hsu.lin@canonical.com>
Date: Tue,  4 Aug 2020 18:18:01 +0800

> This patchset will address the false-negative return value issue
> caused by the following:
>   1. The return value "ret" in this script will be reset to 0 from
>      the beginning of each sub-test in rtnetlink.sh, therefore this
>      rtnetlink test will always pass if the last sub-test has passed.
>   2. The test result from two sub-tests in kci_test_encap() were not
>      being processed, thus they will not affect the final test result
>      of this test.

Series applied, thank you.