[bpf,0/4] Fix some issues for selftest test_xdp_redirect_multi.sh

Message

Hangbin Liu Oct. 27, 2021, 3:35 a.m. UTC

Jiri reported some issues in test_xdp_redirect_multi.sh. Like
the test logs not cleaned after testing. The tcpdump not terminated cleanly.
arp number count may have false positive. And the most important, after
creating/deleting a lot interfaces, the interface index may exceed the
DEVMAP max entry and cause program xdp_redirect_multi exec failed.

This patch set fix all these issues.

Hangbin Liu (4):
  selftests/bpf/xdp_redirect_multi: put the logs to tmp folder
  selftests/bpf/xdp_redirect_multi: use arping to accurate the arp
    number
  selftests/bpf/xdp_redirect_multi: give tcpdump a chance to terminate
    cleanly
  selftests/bpf/xdp_redirect_multi: limit the tests in netns

 .../selftests/bpf/test_xdp_redirect_multi.sh  | 62 +++++++++++--------
 .../selftests/bpf/xdp_redirect_multi.c        |  4 +-
 2 files changed, 37 insertions(+), 29 deletions(-)

Comments

Daniel Borkmann Nov. 5, 2021, 3:46 p.m. UTC | #1

On 10/27/21 5:35 AM, Hangbin Liu wrote:
> Jiri reported some issues in test_xdp_redirect_multi.sh. Like
> the test logs not cleaned after testing. The tcpdump not terminated cleanly.
> arp number count may have false positive. And the most important, after
> creating/deleting a lot interfaces, the interface index may exceed the
> DEVMAP max entry and cause program xdp_redirect_multi exec failed.
> 
> This patch set fix all these issues.
> 
> Hangbin Liu (4):
>    selftests/bpf/xdp_redirect_multi: put the logs to tmp folder
>    selftests/bpf/xdp_redirect_multi: use arping to accurate the arp
>      number
>    selftests/bpf/xdp_redirect_multi: give tcpdump a chance to terminate
>      cleanly
>    selftests/bpf/xdp_redirect_multi: limit the tests in netns
> 
>   .../selftests/bpf/test_xdp_redirect_multi.sh  | 62 +++++++++++--------
>   .../selftests/bpf/xdp_redirect_multi.c        |  4 +-
>   2 files changed, 37 insertions(+), 29 deletions(-)

Applied, thanks, been fixing up a small merge conflict in the last one due to
8fffa0e3451ab ("selftests/bpf: Normalize XDP section names in selftests"), pls
double check.