| Message ID | 20221010142553.776550-1-xukuohai@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix bugs found by ASAN when running selftests | expand |
On Mon, Oct 10, 2022 at 7:08 AM Xu Kuohai <xukuohai@huawei.com> wrote: > Thanks for the fixes! I left a few comments in a few patches, please address those. But also please provide a commit message, even if a single line one. Kernel style dictates that the commit message shouldn't be empty. And I think none of these fixes are critical enough to go to bpf tree, please target bpf-next for next revision. Thanks. > v3: > - Fix error failure of case test_xdp_adjust_tail_grow exposed by this series > > v2: https://lore.kernel.org/bpf/20221010070454.577433-1-xukuohai@huaweicloud.com > - Rebase and fix conflict > > v1: https://lore.kernel.org/bpf/20221009131830.395569-1-xukuohai@huaweicloud.com > > Xu Kuohai (6): > libbpf: Fix use-after-free in btf_dump_name_dups > libbpf: Fix memory leak in parse_usdt_arg() > selftests/bpf: Fix memory leak caused by not destroying skeleton > selftest/bpf: Fix memory leak in kprobe_multi_test > selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow > selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c > > tools/lib/bpf/btf_dump.c | 47 +++++++++++---- > tools/lib/bpf/usdt.c | 59 +++++++++++-------- > .../bpf/prog_tests/kprobe_multi_test.c | 17 +++--- > .../selftests/bpf/prog_tests/map_kptr.c | 3 +- > .../selftests/bpf/prog_tests/tracing_struct.c | 3 +- > .../bpf/prog_tests/xdp_adjust_tail.c | 7 ++- > 6 files changed, 86 insertions(+), 50 deletions(-) > > -- > 2.30.2 >
On 10/11/2022 9:37 AM, Andrii Nakryiko wrote: > On Mon, Oct 10, 2022 at 7:08 AM Xu Kuohai <xukuohai@huawei.com> wrote: >> > > Thanks for the fixes! I left a few comments in a few patches, please > address those. But also > please provide a commit message, even if a single line one. Kernel > style dictates that the commit message shouldn't be empty. > Will do, thanks > And I think none of these fixes are critical enough to go to bpf tree, > please target bpf-next for next revision. Thanks. > Ok, will target to bpf-next branch, targeting bpf tree just because Documentation/bpf/bpf_devel_QA.rst says bpf-next is for features > >> v3: >> - Fix error failure of case test_xdp_adjust_tail_grow exposed by this series >> >> v2: https://lore.kernel.org/bpf/20221010070454.577433-1-xukuohai@huaweicloud.com >> - Rebase and fix conflict >> >> v1: https://lore.kernel.org/bpf/20221009131830.395569-1-xukuohai@huaweicloud.com >> >> Xu Kuohai (6): >> libbpf: Fix use-after-free in btf_dump_name_dups >> libbpf: Fix memory leak in parse_usdt_arg() >> selftests/bpf: Fix memory leak caused by not destroying skeleton >> selftest/bpf: Fix memory leak in kprobe_multi_test >> selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow >> selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c >> >> tools/lib/bpf/btf_dump.c | 47 +++++++++++---- >> tools/lib/bpf/usdt.c | 59 +++++++++++-------- >> .../bpf/prog_tests/kprobe_multi_test.c | 17 +++--- >> .../selftests/bpf/prog_tests/map_kptr.c | 3 +- >> .../selftests/bpf/prog_tests/tracing_struct.c | 3 +- >> .../bpf/prog_tests/xdp_adjust_tail.c | 7 ++- >> 6 files changed, 86 insertions(+), 50 deletions(-) >> >> -- >> 2.30.2 >> > .